Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Build Fails because of missing setup icon #28

Open
franc6 opened this issue Feb 8, 2019 · 0 comments
Open

Windows Build Fails because of missing setup icon #28

franc6 opened this issue Feb 8, 2019 · 0 comments
Assignees
@JimH44
Labels
bug Something isn't working fixed A fix is in git; fix needs to be reviewed before the issue can be closed
Milestone
1.0

Comments

@franc6
Copy link
Owner

franc6 commented Feb 8, 2019 •
edited
Loading

I missed the reference to the Setup icon in MainForm.Designer.cs at line 645.
@franc6 franc6 added the bug Something isn't working label Feb 8, 2019
@franc6 franc6 added this to the 1.0 milestone Feb 8, 2019
@franc6 franc6 self-assigned this Feb 8, 2019
franc6 pushed a commit that referenced this issue Feb 8, 2019
Fixed #28
4e2e5e0 
Updated code to use IconReader class to get the associated icon for
"test.msi", a file that doesn't need to exist.
@franc6 franc6 added the fixed A fix is in git; fix needs to be reviewed before the issue can be closed label Feb 8, 2019
franc6 pushed a commit that referenced this issue Mar 11, 2019
Fixed #28
e55f718 
Updated code to use IconReader class to get the associated icon for
"test.msi", a file that doesn't need to exist.
@franc6 franc6 assigned JimH44 and unassigned franc6 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimH44 JimH44

Labels
bug Something isn't working fixed A fix is in git; fix needs to be reviewed before the issue can be closed
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@franc6 @JimH44