Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Attribute "name" does not exist for Node "Twig\Node\CheckToStringNode". #332

Closed
jproctor opened this issue Mar 19, 2019 · 1 comment
Closed

Comments

@jproctor
Copy link

Drupal 8.6.11 and 8.6.12 update Twig, which caused a small pile of related problems: at least d.o 3039408, d.o 3040000, d.o 3040210, and d.o 3040269.

The last of those, at least in my case, arose from having an older version of components/_twig-components/tags/pl_trans.tag.php, back when it was called just trans.tag.php. Renaming it fixed the issue so it doesn’t clobber Drupal core’s TwigTransTokenParser, but I notice that it still relies on getAttribute('name') on lines 118 and 120, and that attribute might not exist.

@evanmwillhite
Copy link
Contributor

evanmwillhite commented Mar 20, 2019

Thanks for letting us know. We already have this PR in play, which will change the nature of that from something incorrectly doing Drupal-y things to something simple for PL, so I am going to close this one in favor of that one (particularly the new naming convention fixes the major error). But thanks again! Glad this is in the history, so others can find it too who might be on older versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants