Added Watermark to badges. #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to development
…to development
…to development
…to development
…into development
There was a problem hiding this comment.
@Puranjay25 Have you checked the generated badge? Is it having the watermark?
championpaddler
suggested changes
Mar 26, 2019
There was a problem hiding this comment.
@Puranjay25 Please show screenshot of generated badges . Also Watermark can a bit more impressive.
|
@rajvaibhavdubey @sk9331657 when I try to download the badge..it's showing the following error. |
|
Would be great if this is implemented from the backend side and not to be done using CSS on frontend @Puranjay25 |
|
@yashLadha yes sir, got your point |
abishekvashok
suggested changes
Jun 7, 2019
|
@Puranjay25 please reopen when completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1924
Checklist
developmentbranch.Changes proposed in this pull request:
Screenshots for the change