New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependency on Go to 1.21 #66

Open

dolmen opened this issue May 29, 2024 · 4 comments

Contributor

dolmen commented May 29, 2024 •

edited

Loading

In go.mod, go 1.21
Drop dependency on golang.org/x/exp/constraints and use cmp.Ordered
Drop dependency on golang.org/x/exp/slices
Rewrite Sort to just wrap slices.Sort
Rewrite Equals to use maps.Equals
Rewrite RemoveCommon to use maps.DeleteFunc
Rewrite Clear using the clear built-in

The text was updated successfully, but these errors were encountered:

Member

ldemailly commented May 30, 2024

So I am hoping some day this will just exist in std lib but meanwhile, it only requires first generics release, ie 1.18

I suppose I can make a new release though and keep 1.0 for 1.18

Member

ldemailly commented May 30, 2024 •

edited

Loading

@dolmen are you planning on making a PR :) ?

Contributor Author

dolmen commented Jun 24, 2024

I'm not a user of this module, so I don't intend to do this contribution.

Member

ldemailly commented Jun 25, 2024 •

edited

Loading

Thanks ! wanted to avoid duplicate work! you already did a lot by linking the alternatives etc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment