-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to modify the default viewport breakpoints of the token s
when generating a theme
#257
Comments
It seems that the issue lies in my understanding. The viewport here refers to a range:
Is it possible to add another breakpoint below |
Hey, right now it's not possible to add custom ones. We can add support for generating them in css, however that won't generate new viewports support in the component properties since we don't have the jsx generation supported right now. Would that still be helpful for you? |
Supporting JSX would be ideal. Alternatively, is it possible to add more viewports beyond |
I can add more viewports to make them available as css custom media queries so you will be able to write custom styles using it. Existing viewports would still support customizing their values and those values will be respected when you use them via jsx props. For example, the |
Describe the bug
Unable to modify the default viewport breakpoints of the token
s
when generating a theme. However, it works correctly for other tokens (m
,l
,xl
).To Reproduce
When running the
reshaped theming
command, themin-width
for the tokens
in the generatedmedia.css
is incorrect, while it is correct for the other tokens.Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: