fix: fix lint errors

Author: franklinkim

.golangci.yaml

@@ -84,12 +84,12 @@ linters:
     #- gochecknoglobals # check that no global variables exist [fast: true, auto-fix: false]
     #- gochecknoinits # Checks that no init functions are present in Go code [fast: true, auto-fix: false]
     #- gocognit # Computes and checks the cognitive complexity of functions [fast: true, auto-fix: false]
-    - goconst # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
+    #- goconst # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
     - gocritic # Provides diagnostics that check for bugs, performance and style issues. [fast: false, auto-fix: false]
     #- gocyclo # Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false]
     #- godot # Check if comments end in a period [fast: true, auto-fix: true]
     #- godox # Tool for detection of FIXME, TODO and other comment keywords [fast: true, auto-fix: false]
-    - goerr113 # Golang linter to check the errors handling expressions [fast: false, auto-fix: false]
+    #- goerr113 # Golang linter to check the errors handling expressions [fast: false, auto-fix: false]
     - gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true]
     #- gofumpt # Gofumpt checks whether code was gofumpt-ed. [fast: true, auto-fix: true]
     - goheader # Checks is file header matches to pattern [fast: true, auto-fix: false]
@@ -106,7 +106,7 @@ linters:
     - maintidx # maintidx measures the maintainability index of each function. [fast: true, auto-fix: false]
     - makezero # Finds slice declarations with non-zero initial length [fast: false, auto-fix: false]
     - misspell # Finds commonly misspelled English words in comments [fast: true, auto-fix: true]
-    - nakedret # Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
+    #- nakedret # Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
     #- nestif # Reports deeply nested if statements [fast: true, auto-fix: false]
     - nilerr # Finds the code that returns nil even if it checks that the error is not nil. [fast: false, auto-fix: false]
     - nilnil # Checks that there is no simultaneous return of `nil` error and an invalid value. [fast: false, auto-fix: false]
@@ -117,21 +117,21 @@ linters:
     - nosnakecase # nosnakecase is a linter that detects snake case of variable naming and function name. [fast: true, auto-fix: false]
     - nosprintfhostport # Checks for misuse of Sprintf to construct a host with port in a URL. [fast: true, auto-fix: false]
     #- paralleltest # paralleltest detects missing usage of t.Parallel() method in your Go test [fast: false, auto-fix: false]
-    - prealloc # Finds slice declarations that could potentially be pre-allocated [fast: true, auto-fix: false]
+    #- prealloc # Finds slice declarations that could potentially be pre-allocated [fast: true, auto-fix: false]
     - predeclared # find code that shadows one of Go's predeclared identifiers [fast: true, auto-fix: false]
     - promlinter # Check Prometheus metrics naming via promlint [fast: true, auto-fix: false]
     - revive # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. [fast: false, auto-fix: false]
     - rowserrcheck # checks whether Err of rows is checked successfully [fast: false, auto-fix: false]
     - sqlclosecheck # Checks that sql.Rows and sql.Stmt are closed. [fast: false, auto-fix: false]
     - structcheck # Finds unused struct fields [fast: false, auto-fix: false]
     - stylecheck # Stylecheck is a replacement for golint [fast: false, auto-fix: false]
-    - tagliatelle # Checks the struct tags. [fast: true, auto-fix: false]
+    #- tagliatelle # Checks the struct tags. [fast: true, auto-fix: false]
     - tenv # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17 [fast: false, auto-fix: false]
-    - testpackage # linter that makes you use a separate _test package [fast: true, auto-fix: false]
+    #- testpackage # linter that makes you use a separate _test package [fast: true, auto-fix: false]
     - thelper # thelper detects golang test helpers without t.Helper() call and checks the consistency of test helpers [fast: false, auto-fix: false]
     - tparallel # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes [fast: false, auto-fix: false]
     - unconvert # Remove unnecessary type conversions [fast: false, auto-fix: false]
-    - unparam # Reports unused function parameters [fast: false, auto-fix: false]
+    #- unparam # Reports unused function parameters [fast: false, auto-fix: false]
     - usestdlibvars # A linter that detect the possibility to use variables/constants from the Go standard library. [fast: true, auto-fix: false]
     #- varnamelen # checks that the length of a variable's name matches its scope [fast: false, auto-fix: false]
     - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false]

Makefile

@@ -55,14 +55,24 @@ $(foreach p,$(EXAMPLES),$(eval $(call examples,$(p))))
 ## Run go mod tidy recursive
 .PHONY: lint
 lint:
-	# @golangci-lint run
+	@golangci-lint run
 	@for name in example/*/; do\
 		if [ $$name != "example/node_modules/" ]; then \
 			echo "-------- $${name} ------------";\
 			sh -c "cd $$(pwd)/$${name} && golangci-lint run";\
 		fi \
   done
 
+.PHONY: lint.fix
+lint.fix:
+	@golangci-lint run --fix
+	@for name in example/*/; do\
+		if [ $$name != "example/node_modules/" ]; then \
+			echo "-------- $${name} ------------";\
+			sh -c "cd $$(pwd)/$${name} && golangci-lint run --fix";\
+		fi \
+  done
+
 ## Run go mod tidy recursive
 .PHONY: gomod
 gomod:

build.go

@@ -4,7 +4,6 @@ import (
 	"errors"
 	"fmt"
 	"go/format"
-	"io/ioutil"
 	"os"
 	"path"
 	"path/filepath"
@@ -20,7 +19,7 @@ import (
 func deriveCommonJSMapping(conf *config.Config) {
 	replacer := strings.NewReplacer(".", "_", "/", "_", "-", "_")
 	for _, mapping := range conf.Mappings {
-		mapping.TypeScriptModule = replacer.Replace(mapping.GoPackage) //strings.Replace(strings.Replace(mapping.GoPackage, ".", "_", -1), "/", "_", -1)
+		mapping.TypeScriptModule = replacer.Replace(mapping.GoPackage)
 	}
 }
 
@@ -59,8 +58,7 @@ func getPathForTarget(gomod config.Namespace, goPath string, target *config.Targ
 	}
 }
 
-func Build(conf *config.Config, goPath string) {
-
+func Build(conf *config.Config, goPath string) { //nolint:maintidx
 	deriveCommonJSMapping(conf)
 
 	mappedTypeScript := map[string]map[string]*code{}
@@ -125,7 +123,7 @@ func Build(conf *config.Config, goPath string) {
 
 		pkgName, services, structs, scalars, constantTypes, err := Read(goPaths, conf.Module, packageName, target.Services, missingTypes, missingConstants)
 		if err != nil {
-			_, _ = fmt.Fprintln(os.Stderr, "\t an error occured while trying to understand your code: ", err)
+			_, _ = fmt.Fprintln(os.Stderr, "\t an error occurred while trying to understand your code: ", err)
 			os.Exit(2)
 		}
 
@@ -179,7 +177,7 @@ func Build(conf *config.Config, goPath string) {
 				)
 
 				// write code into file for debugging
-				writeErr := ioutil.WriteFile(filename, []byte(code), 0644)
+				writeErr := os.WriteFile(filename, []byte(code), 0644)
 				if writeErr != nil {
 					_, _ = fmt.Fprintln(os.Stderr, "	could not write go source to file", writeErr)
 					os.Exit(5)
@@ -189,7 +187,7 @@ func Build(conf *config.Config, goPath string) {
 				os.Exit(5)
 			}
 
-			writeErr := ioutil.WriteFile(filename, codeBytes, 0644)
+			writeErr := os.WriteFile(filename, codeBytes, 0644)
 			if writeErr != nil {
 				_, _ = fmt.Fprintln(os.Stderr, "	could not write go source to file", writeErr)
 				os.Exit(5)
@@ -238,9 +236,7 @@ func Build(conf *config.Config, goPath string) {
 
 		_, _ = fmt.Fprintln(os.Stderr, "building structs for go package", goPackage, "to ts module", mapping.TypeScriptModule, "in file", mapping.Out)
 		moduleCode := newCode("	")
-		structIndent := -1
-
-		structIndent = -3
+		structIndent := -3
 
 		commonJSImports(conf, moduleCode, mapping.Out)
 
@@ -251,7 +247,6 @@ func Build(conf *config.Config, goPath string) {
 		}
 		sort.Strings(structNames)
 		for _, structName := range structNames {
-
 			structCode, ok := mappedStructsMap[structName]
 			if ok {
 				moduleCode.app(structCode.ind(structIndent).l("").string())
@@ -264,7 +259,6 @@ func Build(conf *config.Config, goPath string) {
 			_, _ = fmt.Fprintln(os.Stderr, "	failed to update code in", mapping.Out, updateErr)
 		}
 	}
-
 }
 
 func updateCode(file string, code string) error {
@@ -281,10 +275,10 @@ func updateCode(file string, code string) error {
 	if errMkdirAll != nil {
 		return errMkdirAll
 	}
-	oldCode, _ := ioutil.ReadFile(file)
+	oldCode, _ := os.ReadFile(file)
 	if string(oldCode) != code {
 		fmt.Println("	writing file", file)
-		return ioutil.WriteFile(file, []byte(code), 0644)
+		return os.WriteFile(file, []byte(code), 0644)
 	}
 	fmt.Println("	update file not necessary - unchanged", file)
 	return nil

client.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 
 	"github.com/pkg/errors"
@@ -31,7 +31,7 @@ func NewClient() Client {
 	return &bufferedClient{client: defaultHttpFactory(), handle: getHandleForEncoding(EncodingMsgpack), headers: nil}
 }
 
-func NewClientWithHttpClient(client *http.Client) Client {
+func NewClientWithHttpClient(client *http.Client) Client { //nolint:stylecheck
 	if client != nil {
 		return &bufferedClient{client: client, handle: getHandleForEncoding(EncodingMsgpack), headers: nil}
 	} else {
@@ -43,7 +43,7 @@ func newRequest(ctx context.Context, url string, contentType string, buffer *byt
 	if buffer == nil {
 		buffer = &bytes.Buffer{}
 	}
-	request, errRequest := http.NewRequestWithContext(ctx, "POST", url, buffer)
+	request, errRequest := http.NewRequestWithContext(ctx, http.MethodPost, url, buffer)
 	if errRequest != nil {
 		return nil, errors.Wrap(errRequest, "could not create a request")
 	}
@@ -71,7 +71,7 @@ func (c *bufferedClient) SetClientEncoding(encoding ClientEncoding) {
 	c.handle = getHandleForEncoding(encoding)
 }
 
-func (c *bufferedClient) SetTransportHttpClient(client *http.Client) {
+func (c *bufferedClient) SetTransportHttpClient(client *http.Client) { //nolint:stylecheck
 	c.client = client
 }
 
@@ -105,7 +105,7 @@ func (c *bufferedClient) Call(ctx context.Context, url string, endpoint string,
 	// Check status
 	if resp.StatusCode != http.StatusOK {
 		var msg string
-		if value, err := ioutil.ReadAll(resp.Body); err != nil {
+		if value, err := io.ReadAll(resp.Body); err != nil {
 			msg = "failed to read response body: " + err.Error()
 		} else {
 			msg = string(value)

cmd/gotsrpc/gotsrpc.go

@@ -19,8 +19,8 @@ func usage() {
 	fmt.Println(os.Args[0], " path/to/build-config.yml")
 	flag.PrintDefaults()
 }
-func main() {
 
+func main() {
 	flagDebug := flag.Bool("debug", false, "debug")
 
 	flag.Parse()

config/config.go

@@ -2,7 +2,6 @@ package config
 
 import (
 	"errors"
-	"io/ioutil"
 	"os"
 	"path"
 	"path/filepath"
@@ -65,7 +64,7 @@ type Config struct {
 }
 
 func LoadConfigFile(file string) (conf *Config, err error) {
-	yamlBytes, readErr := ioutil.ReadFile(file)
+	yamlBytes, readErr := os.ReadFile(file)
 	if readErr != nil {
 		return nil, errors.New("could not read config file: " + readErr.Error())
 	}
@@ -81,7 +80,7 @@ func LoadConfigFile(file string) (conf *Config, err error) {
 		}
 		conf.Module.Path = absPath
 
-		if data, err := ioutil.ReadFile(path.Join(absPath, "go.mod")); err != nil && !os.IsNotExist(err) {
+		if data, err := os.ReadFile(path.Join(absPath, "go.mod")); err != nil && !os.IsNotExist(err) {
 			return nil, err
 		} else if err == nil {
 			modFile, err := modfile.Parse(path.Join(absPath, "go.mod"), data, nil)

config/config_test.go

@@ -66,7 +66,6 @@ func TestLoadConfig(t *testing.T) {
 	if demoTarget.Services["/service/demo"] != "Service" {
 		t.Fatal("first service is wrong")
 	}
-
 }
 
 func TestLoadConfigFile_GomodAbsolute(t *testing.T) {

error.go

@@ -21,12 +21,12 @@ type Error struct {
 // NewError returns a new instance
 func NewError(err error) *Error {
 	// check if already transformed
-	if v, ok := err.(*Error); ok {
+	if v, ok := err.(*Error); ok { //nolint:errorlint
 		return v
 	}
 
 	// skip *withStack error type
-	if _, ok := err.(interface {
+	if _, ok := err.(interface { //nolint:errorlint
 		StackTrace() errors.StackTrace
 	}); ok && errors.Unwrap(err) != nil {
 		err = errors.Unwrap(err)
@@ -87,7 +87,7 @@ func (e *Error) Format(s fmt.State, verb rune) {
 		}
 		fallthrough
 	case 's', 'q':
-		io.WriteString(s, e.Error())
+		_, _ = io.WriteString(s, e.Error())
 	}
 }