Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blurhash_ffi - flutter_blurhash | Bad state? #6

Closed
felipecastrosales opened this issue Aug 5, 2023 · 6 comments
Closed

blurhash_ffi - flutter_blurhash | Bad state? #6

felipecastrosales opened this issue Aug 5, 2023 · 6 comments

Comments

@felipecastrosales
Copy link
Contributor

Hello,

I currently use flutter_blurhash in my projects, and sometimes I come across the Bad state, as you can see here in this issue.

I quickly analyzed the package, and the widget implementation resembles the above.

I would like to know if there is something similar in this package (the issue cited); or if any treatment was carried out for this - and if so, which one?

Thanks

@dhikshith12
Copy link
Member

Yes, i copied the widget implementation from flutter_blurhash for easy migration from flutter_blurhash to blurhash_ffi, but also included this pull request which you also commented on.

you mentioned that Slivers might be causing that issue for you? are you still facing the issue after including that pr in your code (asking because i have not faced such error after including the pr in blurhash_ffi)?

See this stateless widget where i used errorBuilder as proposed in the pr.

class BlurhashBackground extends StatelessWidget {

@felipecastrosales
Copy link
Contributor Author

Hey @dhikshith12, I used blurhash_ffi again in my project, because it looks very interesting to me.

But in my tests, I saw that the Bad State problem persists. Log evidence:

image


Have you any suggestions to this? Is relatively hard to reproduce, unfortunately.

@felipecastrosales
Copy link
Contributor Author

Other question, I see that the plugin requires one more updated NDK version when build, something like this.

This is really intentional and this can affect users?

Best regards, @dhikshith12.

@dhikshith12
Copy link
Member

dhikshith12 commented Aug 31, 2023

Hello, @felipecastrosales, The Bad State issue you mentioned is interesting, and I thought that pr would solve this issue, so I added the pr. However, as you said, this issue persists like in the other package, and I cannot think of a solution because I don't understand what's causing it.

the plugin requires NDK version 25.2.9519653 to compile the native part while building for Android and it's an expected behavior, it's recommended to add this version in your build.gradle of your android/app, However, I did not experience any adverse effects by not adding this ndkVersion in your android/app project apart from a console message.

for my app using this package, the issues pointed out are not fatal and infrequent so it's not a priority.

Good to hear this, please update this thread if you find anything interesting/cause/a way to solve it.

Cheers.

@felipecastrosales
Copy link
Contributor Author

Hey @dhikshith12, I updated the issue with a minimal reproducible example, check below:

@felipecastrosales
Copy link
Contributor Author

This is a behavior that occurs in another package, not this one. I think I can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants