Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't detect iOS version when requesting desktop site by Chrome #555

Open
masato-hi opened this issue Jan 14, 2025 · 0 comments
Open

Can't detect iOS version when requesting desktop site by Chrome #555

masato-hi opened this issue Jan 14, 2025 · 0 comments

Comments

@masato-hi
Copy link

Description

When requesting a desktop site with this MR, it is now detect to be iOS.
#548

However, the version of iOS cannot be detected from the user agent.

How to reproduce

irb(main):034> Browser.new('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/130 Version/11.1.1 Safari/605.1.15').platform.ios?
=> true
irb(main):035> Browser.new('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/130 Version/11.1.1 Safari/605.1.15').platform.version
=> "0"

What do you expect

Add a method to detect iOS desktop site requests.

At the same time, it might be better to revert this MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant