Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the .rnote file appears twice when saving the file in the opened workspace. #1020

Open
Doublonmousse opened this issue Feb 17, 2024 · 3 comments
Labels
bug Something isn't working Mac This issue happens on MacOS

Comments

@Doublonmousse
Copy link
Contributor

Describe the bug

When saving a rnote file in an opened workspace, the .rnote file created is displayed twice, until the display is refreshed

To Reproduce
Steps to reproduce the behavior:

  1. open rnote and save a rnote file in the opened workspace
  2. see the document appear twice in the workspace bar
  3. This is not updated if the workspace view is closed then opened again
  4. This goes away only when clicking on another workspace then displaying the original workspace again

Expected behavior
See the file appear once.

Console Output

2024-02-17T21:32:42.485427Z DEBUG rnote::canvas: Canvas with title: `duplicated` - output-file monitor emitted `changed` - file: Some("/Users/user/Downloads/test/duplicated.rnote"), other_file: None, event: Created, expect_write: true
2024-02-17T21:32:43.285442Z DEBUG rnote::canvas: Canvas with title: `duplicated` - output-file monitor emitted `changed` - file: Some("/Users/user/Downloads/test/duplicated.rnote"), other_file: None, event: Changed, expect_write: true
2024-02-17T21:32:45.286732Z DEBUG rnote::canvas: Canvas with title: `duplicated` - output-file monitor emitted `changed` - file: Some("/Users/user/Downloads/test/duplicated.rnote"), other_file: None, event: ChangesDoneHint, expect_write: false
image

Desktop (please complete the following information):

  • OS: Mac os Sonoma
  • App Version: main commit 0d98bc9
  • Installation Source: compiled from source
@flxzt flxzt added bug Something isn't working Mac This issue happens on MacOS labels Feb 18, 2024
@Doublonmousse
Copy link
Contributor Author

#1033 Also seems to partially fix this issue. The file is not duplicated anymore.

image

However it does not appear in the same section as the rest of the .rnote file until a refresh occurs.

@flxzt
Copy link
Owner

flxzt commented Feb 29, 2024

Seems to be Mac only, on Linux and Win this does not happen. I wonder if this is a bug in the used DirectoryList, missing a file change event while watching the directory. Because while the file is being written, it might not be recognized as .rnote file, but when it is finished, it should refresh once more and put into the correct section.

@Doublonmousse
Copy link
Contributor Author

Found that this only happen when changing the name of the file and not just keeping the New Document.rnote default name. Seems in this case it creates then rename the file ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Mac This issue happens on MacOS
Projects
None yet
Development

No branches or pull requests

2 participants