Skip to content

Updated README.md with flux cli commands to bootsrap monitoring #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

greenCircuit
Copy link

Added CLI commands to bootstrap all monitoring resources in this repo. Solves problem in case don't want to bootstrap new cluster (you already have your cluster bootstrapped)

Looked deprecated docs https://v2-0.docs.fluxcd.io/flux/guides/monitoring/ and there is no equivalent cli commands to inside updated docs.

Let me know if you want to any questions/formatting is correct/would like to add more changes

Added CLI commands to bootstrap all monitoring resources in this repo. Solves problem in case don't want to bootstrap new cluster (you already have your cluster bootstrapped)

Looked deprecated docs https://v2-0.docs.fluxcd.io/flux/guides/monitoring/ and there is no equivalent cli commands to inside updated docs. 


Signed-off-by: greenCircuit <[email protected]>
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

We need to reorder the flux create commands for configs and controllers. If you look at the cluster configuration, the Kustomization that deploys the configs dependsOn the Kustomization that deploys the controllers. This is because the configs Kustomization deploys CRs whose CRDs are installed in the cluster by the controllers Kustomization. In the current order the commands would fail. Did you test this example?

@stefanprodan
Copy link
Member

You shouldn't be using the create commands if you have bootstraped a cluster, all things should be committed to Git, that's the reason we remove the CLI commands. All you need is to copy this file https://github.com/fluxcd/flux2-monitoring-example/blob/main/clusters/test/monitoring.yaml and add the GitRepo defintion on top.

@greenCircuit
Copy link
Author

@matheuscscp All k8s objects came out just fine. I created all objects at the same time without wait command. So I guess that all flux object reconciled eventually.
@stefanprodan I didn't see the that file. That exactly what I was looking to bootstrap monitoring for flux!

Looks that there is already solution for deploying all monitoring from monitoring.yaml. Would you like me to add that add inside README.md since it is not fully documented and it is not too obvious that this file exists? Otherwise we can close the pull request.

Also, thank you for your contributions, you make my life easier.

@stefanprodan
Copy link
Member

Looks that there is already solution for deploying all monitoring from monitoring.yaml. Would you like me to add that add inside README.md since it is not fully documented and it is not too obvious that this file exists?

@greenCircuit yes please, we also need to mention that people should add a GitRepository on top of the monitoring.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants