Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FAQ templating format and change reference of $workload to $target. #1456

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix FAQ templating format and change reference of $workload to $target. #1456

merged 1 commit into from
Aug 21, 2023

Conversation

kellyfj
Copy link
Contributor

@kellyfj kellyfj commented Jul 7, 2023

As per https://docs.flagger.app/usage/metrics#custom-metrics

  1. There is no workload variable
  2. The templating style is {{ namespace }} not $namespace

@kellyfj
Copy link
Contributor Author

kellyfj commented Jul 11, 2023

@stefanprodan Please let me know if I missed any steps in my changes thanks - this is my first PR to this repo. Thanks!

aryan9600
aryan9600 requested changes Jul 13, 2023
View reviewed changes
docs/gitbook/faq.md Outdated Show resolved Hide resolved
@aryan9600 aryan9600 merged commit ee37069 into fluxcd:main Aug 21, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan9600 aryan9600 aryan9600 approved these changes

@stefanprodan stefanprodan Awaiting requested review from stefanprodan stefanprodan is a code owner

Assignees
No one assigned
Labels
kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyfj @aryan9600 @stefanprodan