Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of multiple Intervals #1618

Open
shivamnarula opened this issue Mar 14, 2024 · 6 comments
Open

Possibility of multiple Intervals #1618

shivamnarula opened this issue Mar 14, 2024 · 6 comments

Comments

@shivamnarula
Copy link

Describe the feature

Support for specifying intervals according to stepWeights.

What problem are you trying to solve?
Suppose we specify stepWeights with [10,20,50] and interval as 5m. Shifting traffic from 50% -> 100% in 5 mins seems like a big deal and also we don't want to delay promotion by introducing multiple steps.

Proposed solution

What do you want to happen? Add any considered drawbacks.
A way to specify Intervals in a list which should be equal to number of stepWeights given.
No, no drawbacks considered yet.

Any alternatives you've considered?

Is there another way to solve this problem that isn't as good a solution?
No

@LiZhenCheng9527
Copy link
Contributor

Do you want to specify intervals for each stepweights in test phase, or do you want to specify step weights and intervals for the 50%->100% rollout phase?

@shivamnarula
Copy link
Author

I wish to specify intervals for each stepweights in test phase.

@stefanprodan
Copy link
Member

Shifting traffic from 50% -> 100% in 5 mins seems like a big deal and also we don't want to delay promotion by introducing multiple steps.

How are you introducing delay, if you add [10,20,50,70,100]? There is no difference from being able to say 50 -> 100 in 10 minutes.

@LiZhenCheng9527
Copy link
Contributor

Can you give practical scenarios for using this feature?

@shivamnarula
Copy link
Author

We have a few services having high qps, and going from 5% to 10% in let's say 5mins won't cause an issue in downstream services performance, where as in the same 5mins duration going from 50% to 75% or 80% could cause issue, if bad code is pushed.
Also, we don't want to add lots of stepweights which could delay promotion for a good amount of period.

@shivamnarula
Copy link
Author

What do you guys think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants