Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodDisruptionBudget - Feature request to be managed by Flagger #1604

Open
AshDerTest opened this issue Mar 1, 2024 · 1 comment
Open

PodDisruptionBudget - Feature request to be managed by Flagger #1604

AshDerTest opened this issue Mar 1, 2024 · 1 comment

Comments

@AshDerTest
Copy link

Describe the feature

Currently with PDB creation, the selector labels are used to determine the pods being monitored.
When Flagger deploys the {app.kubernetes.io/name:} is updated to have -primary attached to the end.
Is it possible to get Flagger to manage the PDD and create a Primary version.

Proposed solution

Add section in canary yaml in flagger

spec:
targetRef:
apiVersion: apps/v1
kind: Deployment
name: myapp-primary

other configuration options for Flagger

podDisruptionBudget:
name: myapp-pdb
enabled: true

to monitor and maintain the PDB

Any alternatives you've considered?

  • Would require a new set of selector labels (using helm)
  • Manul scripts not ideal
@LiZhenCheng9527
Copy link
Contributor

Can you describe in more detail your thoughts on this part of the Pod labels change or label selector change in deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants