Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit concurrent processing canaries #1069

Open
timsanwald opened this issue Dec 3, 2021 · 0 comments · May be fixed by #1568
Open

Limit concurrent processing canaries #1069

timsanwald opened this issue Dec 3, 2021 · 0 comments · May be fixed by #1568

Comments

@timsanwald
Copy link

Describe the feature

It would be cool if we can restrict the concurrent amount of processing canaries.

What problem are you trying to solve?
With a large amount of apps pointing to a "base configmap" e.g. jaeger url, changing values in this configmap triggers all canaries at the same time. The cluster itself though doen't have enough resources to start a second pod of each of the canaries at the same time. This can lead to not starting pods and thus to failing canaries, which have to be triggered then manually.

Proposed solution

A configuration parameter for flagger to process x canaries at the same time.

Any alternatives you've considered?

  • Scale the cluster and be prepared for this event -> high costs & unnecessary compute resources
  • high timeout for startup probe of canaries -> just masks the problem and more canaries will result in the same error at some point in time
louishalbritter added a commit to louishalbritter/flagger that referenced this issue Dec 11, 2023
@louishalbritter
add maxConcurrentCanaries flag to limit concurrent progressing canaries
cf8e4d3 
This adds a flag to limit concurrent progessing canaries to avoid high
requests of resources at once.

The flag will not take effect if set to "0", which is default.

Closes fluxcd#1069

Signed-off-by: Louis Halbritter <[email protected]>
@louishalbritter louishalbritter linked a pull request Dec 11, 2023 that will close this issue
Open
louishalbritter added a commit to louishalbritter/flagger that referenced this issue Feb 8, 2024
@louishalbritter
add maxConcurrentCanaries flag to limit concurrent progressing canaries
0fbdead 
This adds a flag to limit concurrent progessing canaries to avoid high
requests of resources at once.

The flag will not take effect if set to "0", which is default.

Closes fluxcd#1069

Signed-off-by: Louis Halbritter <[email protected]>
louishalbritter added a commit to louishalbritter/flagger that referenced this issue Feb 8, 2024
@louishalbritter
add maxConcurrentCanaries flag to limit concurrent progressing canaries
5dd58b7 
This adds a flag to limit concurrent progessing canaries to avoid high
requests of resources at once.

The flag will not take effect if set to "0", which is default.

Closes fluxcd#1069

Signed-off-by: Louis Halbritter <[email protected]>

chore: update Helm default values and README

Signed-off-by: Louis Halbritter <[email protected]>
louishalbritter added a commit to louishalbritter/flagger that referenced this issue Mar 12, 2024
@louishalbritter
add maxConcurrentCanaries flag to limit concurrent progressing canaries
03cfb87 
This adds a flag to limit concurrent progessing canaries to avoid high
requests of resources at once.

The flag will not take effect if set to "0", which is default.

Closes fluxcd#1069

Signed-off-by: Louis Halbritter <[email protected]>

chore: update Helm default values and README

Signed-off-by: Louis Halbritter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add maxConcurrentCanaries flag to limit concurrent progressing canaries louishalbritter/flagger
1 participant
@timsanwald