change image references to reference the new organization

[ilithanos]

When the build pipeline fix is merged, the next logical step would be to update the toolings and deployments to pull images from this organization instead of the weaveworks organization.

Current places i've found so far:

• Helm Chart
• Tilt
• Makefile
• tools/check-runner-images.sh
• config/*
• controllers/tf_controller_runner.go
• controllers/tc000260_runner_pod_test.go
• Lots of places in documentation

[chanwit]

Thank you so much for curating this list @ilithanos 💯

[ilithanos]

i'll start going through this list and fixing what i find.

Will do it in multiple smaller PR's so reviewing and testing is easier.

[ilithanos]

@chanwit When going over the helm chart how much rebranding to tofu controller is wanted?

For now my thought is fixing the gcr urls and the helm repo urls and leaving it at that. But if you want every tf-controller string/reference to be changed to tofu-controller i'll do that while i'm at it.

[chanwit]

Hi @ilithanos

agreed
the first priority is to make things work, so it's fine to fix only things needed.

[ilithanos]

So far i've chosen to leave configuration parameter names containing the tf-controller and tf namings alone for backwards compatibility. As changing these will invalidate current configurations used by users.

[ilithanos]

I haven't gone through the documentation again yet, to evaluate if we are some with that part.

Tilt is still missing a few things. I have no experience in using tilt, but I'll see what I can come up with the following days.

[chanwit]

Tilt was very useful to us when debugging a complex controller + runner behaviour.

[ilithanos]

Good to know, I'll have to try it out. It's just one of the tools I haven't run into yet.

@kasper-leFevre could I get you to verify that the documentation references are all fixed?

@akselleirv I've noticed you are digging into the Tilt setup, would you mind taking on the registry references etc while you are at it?

Just trying to get an overview of what we still need to get done on this one so we can get it finished up. Thanks to everyone for helping out ❤️

[akselleirv]

@ilithanos I made the Tilt setup functionally work in https://github.com/flux-iac/tofu-controller/pull/1224/files.

I can see that there are some references to tf-controller. I can change them to tofu-controller.

[chanwit]

ping @ilithanos
could we have a quick update of this issue please.
what are left to do to make it complete?

cc other maintainers @akselleirv @yitsushi

[akselleirv]

Hello @chanwit, I’m at KubeCon this week so a bit busy, but I’ll take a look at this next week if that is fine.

[ilithanos]

@chanwit since i havn't heard back from the others i tagged, i'll go through it myself as soon as i can and update it.

I'll leave the tilt part for @akselleirv

[chanwit]

Thank you @ilithanos 👍

[akselleirv]

@ilithanos all is good with the Tiltfile. Only thing left is to update the Helm chart references after it has been renamed from tf-controller to tofu-controller.

[ilithanos]

There are still a few places where the name is wrong in the docs @chanwit i'll look into it when i'm done with the helm chart + ci stuff related to that.

[ilithanos]

Update: I've updated and renamed helmchart to fit with rc.4.

I think i saw a few places in the documentation that still needs fixing, but i havn't had the to go through it.

[ilithanos]

Tilt file has been updated. (Thanks @akselleirv)

Still need to find time to look through the documentation.

@chanwit Since versions are tied to the tofu-controller versioning, are we able to actually release the new chart without releasing a new controller rc?

[chanwit]

Cutting a new RC would be fine for me.