Skip to content

3.32 (hotfix) branch appears unhealthy after #169289 #169405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matanlurey opened this issue May 24, 2025 · 4 comments · May be fixed by flutter/cocoon#4723
Open

3.32 (hotfix) branch appears unhealthy after #169289 #169405

matanlurey opened this issue May 24, 2025 · 4 comments · May be fixed by flutter/cocoon#4723
Assignees
@matanlurey
Labels
infra: cocoon Related to the dashboard or cocoon server infra: release Release-related requests and tooling P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team

Comments

@matanlurey
Copy link
Contributor

After #169289, post-submits are consistently failing, but for a reason I can't explain, passing after a re-run. I would not want to release in this state without understanding further - or we need a revert and further investigation.

See https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.32-candidate.0.

/cc @jtmcdole
@matanlurey matanlurey added P0 Critical issues such as a build break or regression team-android Owned by Android platform team infra: release Release-related requests and tooling labels May 24, 2025
@gmackall
Copy link
Member

It looks like ci is using the wrong dependencies:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8714054428579007121/+/u/setup_build/run_recipe

"dependencies": [
{
"version": "version:36v1",
"dependency": "android_sdk"
},

But the ci.yaml on that branch indicates it should be using 35v1
https://github.com/flutter/flutter/blob/flutter-3.32-candidate.0/.ci.yaml#L52

@gmackall
Copy link
Member

But the re-runs are using the correct versions, for some reason 🤷
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8714053712286044289/+/u/setup_build/run_recipe

@matanlurey
Copy link
Contributor Author

The issue is we are getting targets from ToT. This is a bug!

@matanlurey matanlurey assigned matanlurey and unassigned reidbaker and gmackall May 24, 2025
@matanlurey matanlurey added infra: cocoon Related to the dashboard or cocoon server team-infra Owned by Infrastructure team and removed team-android Owned by Android platform team labels May 24, 2025
@jtmcdole
Copy link
Member

But the re-runs are using the correct versions, for some reason 🤷 https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8714053712286044289/+/u/setup_build/run_recipe

The double failure on one of the tasks is still getting "version": "version:36v1"

The issue is we are getting targets from ToT. This is a bug!

Shouldn't ToT only be used to filter the targets locally?

@matanlurey matanlurey linked a pull request May 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matanlurey matanlurey

Labels
infra: cocoon Related to the dashboard or cocoon server infra: release Release-related requests and tooling P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix backfill execution based on ToT target comparison. matanlurey/cocoon
4 participants
@matanlurey @reidbaker @jtmcdole @gmackall