Merge pull request serge-sans-paille#1106 from serge-sans-paille/fix/np_remainder

Fix remainder implementation

Author: serge-sans-paille

pythran/pythonic/include/numpy/remainder.hpp

@@ -12,8 +12,18 @@ PYTHONIC_NS_BEGIN
 
 namespace numpy
 {
+  namespace wrapper
+  {
+    template <class T0, class T1>
+    auto remainder(T0 const &x, T1 const &y)
+        -> decltype(x - y * xsimd::floor(x / y))
+    {
+      return x - y * xsimd::floor(x / y);
+    }
+  }
+
 #define NUMPY_NARY_FUNC_NAME remainder
-#define NUMPY_NARY_FUNC_SYM xsimd::remainder
+#define NUMPY_NARY_FUNC_SYM wrapper::remainder
 #include "pythonic/include/types/numpy_nary_expr.hpp"
 }
 PYTHONIC_NS_END

pythran/pythonic/numpy/remainder.hpp

@@ -13,7 +13,7 @@ PYTHONIC_NS_BEGIN
 namespace numpy
 {
 #define NUMPY_NARY_FUNC_NAME remainder
-#define NUMPY_NARY_FUNC_SYM xsimd::remainder
+#define NUMPY_NARY_FUNC_SYM wrapper::remainder
 #include "pythonic/types/numpy_nary_expr.hpp"
 }
 PYTHONIC_NS_END

pythran/tests/test_numpy_func1.py

@@ -295,6 +295,12 @@ def test_isclose7(self):
                       numpy.array([[-1.01, 1e-10+1e-11, -0, 7.],[9., 1e-10, 0., float('NaN')]]),
                       np_isclose7=[NDArray[float,:], NDArray[float,:,:]])
 
+    def test_remainder0(self):
+        self.run_test("def np_remainder0(u, v): from numpy import remainder; return remainder(u, v)",
+                      numpy.array([9., 9., -9., -9.]),
+                      numpy.array([2., -2., 2., -2.]),
+                      np_remainder0=[NDArray[float,:], NDArray[float,:]])
+
     def test_numpy_ones_list(self):
         self.run_test(
             "def np_ones_list(u): from numpy import ones; return ones([u,u])",