-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted v7 improvements #1677
Comments
Why not use a milestone for this? |
Some thoughts I think we should have in mind: The more exposed an API is, the more havoc breaking it will cause. This discussion has some interesting points on this topic |
After release of V6 there are issues reported which cannot be (completely) realized before V7 because of breaking changes.
This issue lists all pending changes including link to related issue(s). It will be updated permanently.
ComparableAssertions
more generic - draftGreaterOrEqualTo
(obsolete) methods replaced byGreaterThanOrEqualTo
(Change names of "OrEqualTo" assertion methods #1673)EquivalentValidator
replace the lastIEquivalencyStep
with a hard-coded assertion to replace theNotImplementedException
. See https://github.com/fluentassertions/fluentassertions/blob/master/Src/FluentAssertions/Equivalency/EquivalencyValidator.cs#L76RespectingRuntimeTypes
toRespectingRuntimeTypeProperties
or something like that. See Exception thrown when comparing empty types using 'BeEquivalentTo' with 'RespectingRuntimeTypes' set #1830. Also, it can be confusing because we also haveIncludingAllRuntimeProperties
andIncludingAllDeclaredProperties
AndWhichConstraint
should be executed withinAssertionScope
after base assertion has failed. See discussion on Slack.AsyncFunctionAssertions
as "real" base class (preparation in Prepare constructors ofAsyncFunctionAssertions
to make them protected in V7 #1972).CallerIdentifier
using[CallerArgumentExpression]
.expected
parameter.Expression<>
withFunc<>
AssertionScope.Current
toAssertionScope.ThreadInstance
FailWith
since it does not always throwExcludingNestedObjects
to something with recursive in it or deep vs shallowAndWhichConstraint
fromGenericCollectionAssertions.ContainItemsAssignableTo<T>
EquivalencyValidator
and some other "internal" classesinternal
The text was updated successfully, but these errors were encountered: