-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'console' gem v1.25 causes LoadError #4487
Labels
bug
Something isn't working
Comments
daipom
changed the title
'console' gem v1.25 caueses LoadError
'console' gem v1.25 causes LoadError
May 7, 2024
There would be two options:
|
This was referenced May 7, 2024
daipom
added a commit
that referenced
this issue
May 22, 2024
console gem v1.25 causes LoadError because it has changed some namepaths (#4487). v1.25 has been supported on the master branch at b15cda4, but on v1.16, we should keep v1.24 to prioritize stability. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
that referenced
this issue
May 22, 2024
console gem v1.25 causes LoadError because it has changed some namepaths (#4487). v1.25 has been supported on the master branch at b15cda4, but on v1.16, we should keep v1.24 to prioritize stability. Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
https://github.com/socketry/console v1.25 series was released on 2024-05-03.
It causes CI failure (Ruby ver >= 3.1): https://github.com/fluent/fluentd/actions/runs/8978822806/job/24659864778?pr=4486
fluentd/lib/fluent/log/console_adapter.rb
Lines 17 to 24 in 236d87d
This is caused by the following path change (
lib/console/terminal/logger.rb
->lib/console/output/terminal.rb
):We need to consider how to handle this new
console
gem ver.To Reproduce
Expected behavior
Tests are executed without errors.
Your Environment
Your Configuration
Your Error Log
Additional context
No response
The text was updated successfully, but these errors were encountered: