-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPUnit internal helper(s) #745
Comments
Hi @norberttech , I would like to help on this. If I am not mistaken there isn't any generic place to create the new helpers. Should we create a |
hey @Bellangelo, awesome! I think I would put it inside of the |
@norberttech, i checked and the Filesystem issue that the original PR was addressing seems to be fixed. I checked a little bit around the project and I noticed that some of the Extractor's tests logic is duplicated so I created a PR for it #1291. Not sure if all the changes are needed but it is a start. Also, since the description of this issue does not contain much info I would really appreciate it if you could add what it is missing currently. |
Since this task was never properly explained, here is a proper description of what we are trying to achieve here: |
I think we can create some very generic fake extractors and define schema for them,for example
and we should make sure all of those datasets keep consistent schema and that they are using all possible entry types. This would make so much easier and more realistic to test not only entire pipeline but also stand-alone scalar functions as we can also create helpers that would just give us one row (and use them inside fake extractors) |
We often start to do copy-paste work in tests, thus we should begin to have some reusable helpers to make our internal tests easier to maintain.
Helpers:
FilesystemHelper
with:create
,delete
for files & directories,The text was updated successfully, but these errors were encountered: