Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides multiple improvements, three are very straight forward:
cut_pads
is turned on, also cut magnet holes by default. I could see an argument to add a booleancut_pads_mag
which is off by default but I refrained to keep the command-line more concise.The next is intended to make it easy to use boxes.py to build grids that drop into existing areas with a fixed size like drawers. Instead of providing the number of grids in the
x
andy
direction you can instead specify the full size (in mm) in thesx
andxy
similar to (https://laserbase.makershop.ch/).I made a few design decisions here:
x, y, sx, sy
are all provided then the minimum size of the box is specified byx and
y(in other words, you are always guaranted
xby
ygrids). If
sxand
sy` are larger than the mininum size, then the grid is centered in the larger base.x
andy
are set to zero then the maximum number of grids is produced to fit within the providedsx
andsy
The next change allows creating grids that are larger than a single work piece. This is similar to how https://laserbase.makershop.ch/Split works (but better). In the makershop version, splits are made arbitrarily. In my implementation, the splits are made down the center between grids and joined with a dovetail joint. A future commit will allow turning the dovetail off and using a straight edge.
In addition, when run in split mode it will also automatically split the box walls and base. I'd really like the box base to use a deeper dovetail, but couldn't figure out how to change dovetail settings mid-render. Help would be appreciated here. In addition, when running in split mode it won't generate a lid.