Skip to content

Use internal function inside and inside_meshgrid' methods #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marc-flex opened this issue Jan 28, 2025 · 0 comments
Open

Use internal function inside and inside_meshgrid' methods #2207

marc-flex opened this issue Jan 28, 2025 · 0 comments
Assignees
@marc-flex
Labels
Charge good first issue

Comments

@marc-flex
Copy link
Contributor 

          So every geometry (so including `Box`) has an [inside](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L89) and [inside_meshgrid](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L179) method. Can these be used directly instead of this? It seems like this handles some special cases but wondering if you've considered those.

Originally posted by @momchil-flex in #2205 (comment)
@marc-flex marc-flex self-assigned this Jan 28, 2025
@marc-flex marc-flex changed the title So every geometry (so including Box) has an [inside](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L89) and [inside_meshgrid](https://github.com/flexcompute/tidy3d/blob/948098a3940500b7dee71cdefe5bd94600717378/tidy3d/components/geometry/base.py#L179) method. Can these be used directly instead of this? It seems like this handles some special cases but wondering if you've considered those. Use internal function inside and `inside_meshgrid'' methods Jan 28, 2025
@marc-flex marc-flex changed the title Use internal function inside and `inside_meshgrid'' methods Use internal function inside and inside_meshgrid' methods Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc-flex marc-flex

Labels
Charge good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marc-flex