Why am I not getting all the full ring?

[tansanDOTeth]

I am testing this code, and I am not sure why this isn't returning back the expected hexagons.

Code:

import { Grid, defineHex, rectangle, ring, spiral } from 'honeycomb-grid'

const Tile = defineHex({ dimensions: 30, orientation: "FLAT" })
const grid = new Grid(Tile, rectangle({ width: 1000, height: 1000 }))
const traverseStrategy = ring({ center: [0, 0], radius: 2 })
grid.traverse(traverseStrategy).forEach(console.log)

Output:

-------------------------------------------------
$ node index.js
$ { q: 2, r: 0 }
$ { q: 1, r: 1 }
$ { q: 0, r: 2 }
$ { q: 2, r: -1 }

1. I would expect 19 hexagons for "radius" 2. What am I doing wrong in the above?
2. Could someone explain what dimensions mean in defineHex? is this the number of sides? I tried Googling "dimensions" in the context of a hexagon and I don't see any definition that might explain what that means. I see it creates an xRadius, and yRadius, but unsure what this is for. A visual illustration would be much appreciated!
3. I have a similar issue with spiral. It seems to be outputting incorrect hex coordinates. Am I doing something wrong? Code below.

Code:

import { Grid, defineHex, rectangle, ring, spiral } from 'honeycomb-grid'

const Tile = defineHex({ dimensions: 30, orientation: "FLAT" })
const grid = new Grid(Tile, rectangle({ width: 1000, height: 1000 }))

const traverseStrategy = spiral({ start: [0, 0], radius: 5 })
grid.traverse(traverseStrategy).forEach(console.log)

Output:

$ node index.js
$ { q: 0, r: 0 }
$ { q: 1, r: 0 }
$ { q: 0, r: 1 }
**$ { q: 2, r: -1 }**
$ { q: 2, r: 0 }
$ { q: 1, r: 1 }
$ { q: 0, r: 2 }
$ { q: 3, r: -1 }
$ { q: 3, r: 0 }
$ { q: 2, r: 1 }
$ { q: 1, r: 2 }
$ { q: 0, r: 3 }
$ { q: 4, r: -2 }
$ { q: 4, r: -1 }
$ { q: 4, r: 0 }
$ { q: 3, r: 1 }
$ { q: 2, r: 2 }
$ { q: 1, r: 3 }
$ { q: 0, r: 4 }
$ { q: 5, r: -2 }
$ { q: 5, r: -1 }
$ { q: 5, r: 0 }
$ { q: 4, r: 1 }
$ { q: 3, r: 2 }
$ { q: 2, r: 3 }
$ { q: 1, r: 4 }
$ { q: 0, r: 5 }

The fourth coordinate seems out of place. I would have expected q: -1, r: 1.

[flauwekeul]

Hi,

1. https://abbekeultjes.nl/honeycomb/guide/traversing-grids.html please read the documentation. Coordinates [0, 0] are in the top left corner of the rectangle. When you traverse outside this rectangle, by default, any hexes outside are skipped.
2. https://abbekeultjes.nl/honeycomb/api/interfaces/HexOptions.html#dimensions
3. See 1

[tansanDOTeth]

@flauwekeul Looks like that worked! Thank you! The only unexpected thing is how it jumps to a hexagon so it's not really a spiral, but there is a fix here: #60

Edit: Actually, that looks out of date now. Is there a way to change the spiral in the new API? https://github.com/flauwekeul/honeycomb/blob/master/src/grid/traversers/spiral.ts

[flauwekeul]

Currently, spiral() can't be configured to do what you need. I'll look into a solution. I'll get back to you within a week or so.

[tansanDOTeth]

Currently, spiral() can't be configured to do what you need. I'll look into a solution. I'll get back to you within a week or so.

I ended up writing my own algorithm to keep traversing until X hex is created! Thanks for the library, really appreciate the design to let us traverse.

[flauwekeul]

Cool. Did you create a custom traverser?

[tansanDOTeth]

Cool. Did you create a custom traverser?

Yeah, that's what I did in the end!

[flauwekeul]

Tomorrow I have more time, I'll answer your questions then. Op ma 2 jan. 2023 11:26 schreef tansan.eth ***@***.***>:

…

1. Ah that makes a lot of sense. Is there a way to generate a spiral by X hexagons? Ex, I know I need X hexagons, but would like it in the shape of a spiral. I am guessing I would probably have to generate the rectangle first, but that would be pretty wasteful. 2. I came across that and even tried looking at the code, but it didn't have clarify the necessity of that. Is there anything else I can read? 3. 👍 Thank you for the reply! I appreciate the help. — Reply to this email directly, view it on GitHub <#93 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMSRKJPJITRKYD7O2QQ2F3WQKUPBANCNFSM6AAAAAATOS6Y74> . You are receiving this because you commented.Message ID: ***@***.***>

[tansanDOTeth]

🙇