Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Throw on 500 Errors #136

Open
xjamundx opened this issue Feb 6, 2013 · 2 comments
Open

Don't Throw on 500 Errors #136

xjamundx opened this issue Feb 6, 2013 · 2 comments

Comments

@xjamundx
Copy link
Contributor

xjamundx commented Feb 6, 2013

Currently resource.js does this on line 139:

if (e.status >= 500) {
    throw new(Error)(e);
}

We shouldn't throw in this case but let the engines handle it however they please.

@xjamundx
Copy link
Contributor Author

xjamundx commented Feb 6, 2013

I'm dealing with a particularly annoying server right now (PHP serialized data, bla bla bla), so I'm looking for some flexibility in my engine :)

@indexzero
Copy link
Member

Yeah, I agree here, it's an async thing so throwing has unintended side-effects

xjamundx added a commit to xjamundx/resourceful that referenced this issue Mar 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants