Couch breaks with concurrent saves

[chbm]

Couchdb.prototype.put = function (id, doc, callback) {
  delete doc.id;
  return this.request('put', id, doc, function (e, res) {

put alters the original doc which means a save on the object will fail and create a duplicate cause we're saving a document without id. I'm not sure of the way to go here. Make a deep copy of the doc in put ?

[chbm]

Otoh I just realized this could be used as a crude semaphore. If !id return an error right away or better yet make the callback wait, return a error and the new document.

[Marak]

The couch engine should be using the _rev property for updating the same document multiple times.

If you can you provide a runnable code example or test reproducing the issue, I'd be glad to help you get it to work.

Thanks!

[chbm]

Well, the scenario is fairly simple but requires multiple code paths share the same object instance. If the following sequence runs:
obj.save(cb);

obj.save(othercb)

The 2nd save will find a obj without id but doesn't fail, instead it just creates a fresh duplicate under some new id.
One simple way is to say "you must always get() a fresh copy of the document before changing it" but I don't think this is a fair solution for a good deal of use cases.

[Marak]

If you can you provide a runnable code example or test reproducing the issue, I'd be glad to help you get it to work.