Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why --disable-gpu-sandbox? #452

Open
t3dium opened this issue Jun 3, 2024 · 3 comments
Open

Why --disable-gpu-sandbox? #452

t3dium opened this issue Jun 3, 2024 · 3 comments

Comments

@t3dium
Copy link

t3dium commented Jun 3, 2024

Why is this flag being passed, which could potentially reduce security, if users are using wayland with element?

I've just tried using element with wayland, on nvidia, and I haven't encountered any issues despite not disabling the gpu sandbox.

I had a look into this and it appears it's only problematic for webGL?

https://wiki.archlinux.org/title/chromium

If you are using Chromium with Bumblebee, WebGL might crash due to GPU sandboxing. In this case, you can disable GPU sandboxing with optirun chromium --disable-gpu-sandbox.

However, element doesn't even require webGL to my knowledge.

@SISheogorath
Copy link
Collaborator

The background to the issue can be found here: #234

It was never revisited, it might be resolved by now.

@t3dium
Copy link
Author

t3dium commented Jun 5, 2024

The background to the issue can be found here: #234

It was never revisited, it might be resolved by now.

Yeah it works perfectly fine on wayland now, without needing that fix:

image

@SISheogorath
Copy link
Collaborator

Uhm, that's probably not that easy given we don't know the original configuration, we don't know which graphics card and which drivers triggered the problem.

We also don't know with which combination it works for you. I'm not saying we can't remove the option but we should get a sample size larger than 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants