Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a License file #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added a License file #39

wants to merge 2 commits into from

Conversation

Riverfount
Copy link
Member

Close #37

@jairomr
Copy link
Contributor

jairomr commented Apr 18, 2020

Seria bom adicionar a licença nos arquivo pyproject.toml

@mtrsk
Copy link
Contributor

mtrsk commented Apr 19, 2020

@Riverfount Se for usar GPL como o @jairomr mencionou seria legal adicionar essa informação também no pyproject.toml. Consultando as docs acho que ficaria algo assim:

[tool.poetry]
name = ...
version = ...
description = ...
authors = ...
license = "GPL-3.0-only"

@Riverfount
Copy link
Member Author

e for usar GPL como o @jairomr mencionou seria legal adicionar

Feito. Só fazerem a revisão e mergear o PR!

@mtrsk
Copy link
Contributor

mtrsk commented Apr 19, 2020 •
edited

Foi sugerida MIT também no issue, melhor ver o que os reviewers acham da ideia de usar GPL. Se eles não quiserem eu até entendo, as vezes quem olha o projeto por fora acaba não usando só por medo da licença.

marcuxyz
marcuxyz approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@marcuxyz marcuxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like good for me.

mtrsk
mtrsk reviewed Apr 19, 2020
View reviewed changes
service/pyproject.toml Outdated Show resolved Hide resolved
rochacbruno
rochacbruno reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisamos discutir melhor isso, se seria melhor GPL, MIT ou simplesmente alguma outra licença super permissiva.

@rochacbruno rochacbruno added help wanted Extra attention is needed question Further information is requested labels Apr 23, 2020
@rochacbruno rochacbruno added this to To do in General Apr 23, 2020
@robsonsilv4
Copy link

Também a BSD como opção.
Mas como o @rochacbruno disse, acho melhor discutir mais um pouco sobre isso.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno left review comments

@mtrsk mtrsk mtrsk left review comments

@marcuxyz marcuxyz marcuxyz approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE help wanted Extra attention is needed question Further information is requested
Projects
General
  
To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license file to the project
6 participants
@Riverfount @jairomr @mtrsk @robsonsilv4 @rochacbruno @marcuxyz