Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make relay request timeout configurable or at least limited. #689

Open
screwyprof opened this issue Sep 26, 2024 · 1 comment
Open

Make relay request timeout configurable or at least limited. #689

screwyprof opened this issue Sep 26, 2024 · 1 comment

Comments

@screwyprof
Copy link

At the moment when a request to relay is made the default context with no timeout is passed which means the request will block until the server replies.

Later on the wait group will block until all the go-routines are done.

If I get it correctly, if we have a faulty relay which doesn't respond quick enough, all the other request still will be waiting.

It would be better if we could set a request timeout for each relay request.

@alextes
Copy link

alextes commented Oct 2, 2024

Not quite. On that same line you link a http client is passed. If you follow the code to where it is constructed you can see some default timeout is passed on it. Not the most obvious but the timeout is set 😄. In other words, by default mev boost only waits a certain time and then works with whatever replies made it in time, if any.

Different calls use different timeouts. If you'd want to control them you can see a short description of cli arguments that control the timeouts here: https://github.com/flashbots/mev-boost#mev-boost-cli-arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants