Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: test release builds in CI #475

Open
metachris opened this issue Mar 16, 2023 · 4 comments
Open

feature-request: test release builds in CI #475

metachris opened this issue Mar 16, 2023 · 4 comments

Comments

@metachris
Copy link
Collaborator

metachris commented Mar 16, 2023

It would be great to test mev-boost binaries after building the release builds in https://github.com/flashbots/mev-boost/blob/main/.github/workflows/release.yaml

A good starting point would be to use Ubuntu 20.04, pull the linux binary from the previous step, and run mev-boost version

See also https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

@ameya-deshmukh
Copy link

@metachris is this still available? Would love to take a shot at this with your guidance😄

@ralexstokes
Copy link
Collaborator

@ameya-deshmukh it would be great if you want to open a PR for this!

@ameya-deshmukh
Copy link

@ralexstokes awesome! Will do.

@matiasADiazPerez
Copy link

matiasADiazPerez commented Aug 21, 2023

Hi team. Is this as simple as to add this job?

 test-binaries:                                                                                       
    needs: release                                                                                     
    runs-on: ubuntu-latest                                                                             
    steps:                                                                                             
      - name: Checkout                                                                                 
        uses: actions/checkout@v3                                                                      
        with:                                                                                          
          fetch-depth: 0                                                                               
      - name: Make directories                                                                         
        run: |                                                                                         
          mkdir -p ./build                                                                             
      - name: Download binaries                                                                        
        uses: actions/download-artifact@v3                                                             
        with:                                                                                          
          name: mev-boost-build                                                                        
          path: ./build                                                                                
      - name: Test binaries                                                                            
        run: |                                                                                         
          cd ./build                                                                                
          tar -xf mev-boost_*_linux_amd64.tar.gz                                                    
          chmod 755  mev-boost                                                                      
          ./mev-boost -version 

This also can be accomplished by adding the Test binaries step right after here. But I think is cleaner to do it in another separated job. I can add a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants