Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apimachinery/pkg/util/wait to implement timeouts #1920

Open
thomasferrandiz opened this issue Mar 20, 2024 · 0 comments
Open

Use apimachinery/pkg/util/wait to implement timeouts #1920

thomasferrandiz opened this issue Mar 20, 2024 · 0 comments

Comments

@thomasferrandiz
Copy link
Contributor

We should stop using infinite loops for long operations like iptables-restore.

Possible Solution

migrate to https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait with a defined timeout where the process crashes after a while if something is not working as expected. Otherwise, it is hard to detect that things are not working well

Note: we need to wait for k8s 1.26 to be deprecated then update k8s deps to 1.27 before doing this since we need newer APIs introduced in 1.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant