Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop connectionDetails #158

Closed
moshloop opened this issue May 20, 2024 · 0 comments · Fixed by flanksource/docs#222
Closed

Drop connectionDetails #158

moshloop opened this issue May 20, 2024 · 0 comments · Fixed by flanksource/docs#222
Assignees
@yashmehrotra
Labels
high

Comments

@moshloop
Copy link
Member

The connectionDetails sub object doesn't read very well I think we should inline the fields.

In the scraper, we can probably just do

aws:
  - {{ .Values | omit ('nameOverride', etc..') | yaml | indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashmehrotra yashmehrotra

Labels
high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove connectiondetails prefix in aws/azure flanksource/docs
2 participants
@moshloop @yashmehrotra