-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoClose
is not respected when manually setting progress
to 1
#1116
Comments
found this while going through the code, see if it helps you |
@shamoilarsi this still does not give the desired behavior. The suggestion in that code will remove the progress bar completely, which I don’t want, I want to see a completed progress bar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Report a bug
What is the current behavior?
When manually setting
progress
to 1 viatoast.update(toastId, { progress: 1 })
, the toast auto closes even whenautoClose: false
is set.Steps to Reproduce + Repro:
const toastId = toast('your message', { autoClose: false })
toast.update(toastId, { progress: 1 })
CodeSandbox: https://codesandbox.io/p/sandbox/react-toastify-autoclose-with-progress-n5d5jg
What is the expected behavior?
If I use
autoClose: false
, then the toast should not close automaticallyWhich versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React 18, chromium based browser on Mac. I'm uncertain how this behaves on old versions of React
The text was updated successfully, but these errors were encountered: