Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary-env: Waiting for WaitGroup before cmd is released #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

binary-env: Waiting for WaitGroup before cmd is released #340

wants to merge 1 commit into from

Conversation

jaynis
Copy link

@jaynis jaynis commented May 17, 2024

I added a wg.Wait() to assure all pipes are read before they are released by cmd.Wait() (see here). Since all the other WaitGroup logic is already there I assume this simply has been missed.

fixes #339

@jaynis jaynis changed the title waiting for WaitGroup before cmd is released binary-env: Waiting for WaitGroup before cmd is released May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binary-env intermittently fails to read from stdout/stderr pipe of spawned subprocess
1 participant
@jaynis