Match upstream PCRE2_SYS_STATIC env variable behavior #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream pcre2-sys crate has tri-state behavior for the PCRE2_SYS_STATIC environment variable, where 0 is force dynamic linking, 1 is force static linking, otherwise it is based off the heuristic. We *do* have the STATIC_PCRE2 feature that upstream doesn't have, but the benefit of an environment variable is that a) it can be set for transitive dependencies, b) it can be set without modifying any code or even locally checking out the project. This does effectively give PCRE2_SYS_STATIC=0 a veto over the STATIC_PCRE2 feature, but that's probably preferable since it gives maximum control to the person ultimately building the downstream app (i.e. fish).
|
For precedent, at least the OpenSSL crate has the vendored feature for direct dependents to request a static build, but also allows the top-level end user to compile a transitive dependency on OpenSSL statically via the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream pcre2-sys crate has tri-state behavior for the
PCRE2_SYS_STATICenvironment variable, where0is force dynamic linking,1is force static linking, otherwise it is based off the heuristic.We do have the
STATIC_PCRE2feature that upstream doesn't have, but the benefit of an environment variable is that a) it can be set for transitive dependencies, b) it can be set without modifying any code or even locally checking out the project.This does effectively give
PCRE2_SYS_STATIC=0a veto over theSTATIC_PCRE2feature, but that's probably preferable since it gives maximum control to the person ultimately building the downstream app.