Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout slightly broken on Actors table #4905

Closed
jamilbk opened this issue May 7, 2024 · 0 comments · Fixed by #4947
Closed

Layout slightly broken on Actors table #4905

jamilbk opened this issue May 7, 2024 · 0 comments · Fixed by #4947
Labels
area/portal Portal, panel, web, control plane, you name it! kind/bug Something isn't working kind/UI Changes related specifically to the admin portal UI

Comments

@jamilbk
Copy link
Member

jamilbk commented May 7, 2024

Can be fixed by not showing all the Group badges and shortening the Identifier badges.

Screenshot 2024-05-07 at 1 13 35 PM
@jamilbk jamilbk added kind/bug Something isn't working kind/UI Changes related specifically to the admin portal UI area/portal Portal, panel, web, control plane, you name it! labels May 7, 2024
@jamilbk jamilbk mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 10, 2024
@jamilbk
fix(portal): Add provider icon to identity/group badges (#4947)
7faacd9 
- Makes the group badges a little easier on the eyes, and reduces their
size to improve layout flow a bit. Allows to more quickly identity
provider adapters at-a-glance.
- Fix group badge wrapping so that long group names don't flow into the
next table cell

Fixes #4905 



<img width="1209" alt="Screenshot 2024-05-10 at 7 24 59 AM"
src="https://github.com/firezone/firezone/assets/167144/fba4190a-af0a-464a-b3b1-9e98505c59fb">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/portal Portal, panel, web, control plane, you name it! kind/bug Something isn't working kind/UI Changes related specifically to the admin portal UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(portal): Add provider icon to identity/group badges firezone/firezone
1 participant
@jamilbk