New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`fdctl configure` should log actions it is taking #1895

Open

mmcgee-jump opened this issue May 16, 2024 · 0 comments

Contributor

mmcgee-jump commented May 16, 2024 •

edited

There is a loose convention of this, eg,

NOTICE  ethtool ... unconfigured ... device `ens3f0` does not have right number of channels, got 2, expected 4
NOTICE  ethtool ... configuring

But these configure commands are changing the user system, so should be extremely explicit about what they are doing, eg,

NOTICE  ethtool ... unconfigured ... device `ens3f0` does not have right number of channels, got 2, expected 4
NOTICE  EXEC `ethtool --set-channels ens3f0 combined 4`
NOTICE  ethtool ... configuring

As an added bonus, we should probably prompt for y/n on each of these actions, unless a --silent type of flag is passed.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment