-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy with minInstances
throws an error for framework deployment
#7042
Comments
I learnt some more about what happens. While a new revision is created, traffic actually doesn't route there as far as I can tell. I found out by my deleting the previous revision (which did not have minInstances) which immediately broke our site. Anyway; would be nice to be able to deploy a site that does not suffer from cold starts. |
so what is recommended never set minInstances or set pingTags to false ? |
I have the same issue. Not sure what to do... |
Any update on this ? maybe a workaround |
We ended up migrating the deployment to Cloud Run from Firebase. |
[REQUIRED] Environment info
firebase-tools: 13.7.1
Platform: Ubuntu
[REQUIRED] Test case
Adding this configuration in
firebase.json
to you Firebase hosted Next.js project causes some inconveniences:I think it adds, hidden from the developer, something like this to the deployment configuration (https://firebase.google.com/docs/hosting/full-config#rewrite-cloud-run-container) :
Related items: #6484 and #6684
[REQUIRED] Steps to reproduce
firebase init hosting
minInstances
setting to your hosting configuration.[REQUIRED] Expected behavior
Successful deploys with no errors. Alternatively, a warning stating that pinTag was not set if that's what happens. Maybe remove
pinTag: true
from wherever it's set or allow settingpinTag: false
in the frameworks configuration.[REQUIRED] Actual behavior
The deploy script prints the following error:
Error: Function ssrhelloworld has minInstances set and is in a rewrite pinTags=true. These features are not currently compatible with each other.
.However, when viewing the Function and associated Cloud Run,
minInstances
seem to be set and the deploy is successful. A tag is not associated with the revision. Here's a screenshot from the page of the associated Cloud Run:The text was updated successfully, but these errors were encountered: