Skip to content

Commit 4a581df

Browse files
authored
Merge branch 'main' into leoortizz_nextjsintegrationtests
2 parents 0bfd4fc + 3eae1c1 commit 4a581df

File tree

7 files changed

+10
-7
lines changed

7 files changed

+10
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Updated TypeScript templates for `ext:dev:init` to fix build failures (#9524)

scripts/publish.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ if [[ $VERSION != "preview" ]]; then
142142
git push origin main --tags
143143
echo "Pushed to GitHub."
144144

145-
echo "Publishing release notes..."
146-
hub release create --file "${RELEASE_NOTES_FILE}" "v${NEW_VERSION}"
147-
echo "Published release notes."
145+
echo "Publishing draft release notes..."
146+
hub release create --draft --file "${RELEASE_NOTES_FILE}" "v${NEW_VERSION}"
147+
echo "Published draft release notes."
148148
else
149149
echo "Publishing preview version to npm..."
150150
npx [email protected] --before-script ./scripts/clean-shrinkwrap.sh -- --tag preview

scripts/publish/cloudbuild.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ steps:
135135
- |
136136
if [ "${_VERSION}" != "preview" ]; then
137137
node /usr/src/app/pipeline.js --package=firebase-tools@latest --publish
138+
echo "Please review the draft release notes at https://github.com/${_REPOSITORY_ORG}/${_REPOSITORY_NAME}/releases. If it looks good, publish it"
138139
else
139140
echo "Skipping firepit build for preview version."
140141
fi

templates/extensions/typescript/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* https://firebase.google.com/docs/extensions/publishers
99
*/
1010

11-
import * as functions from "firebase-functions";
11+
import * as functions from "firebase-functions/v1";
1212

1313
exports.greetTheWorld = functions.https.onRequest(
1414
(req: functions.Request, res: functions.Response) => {

templates/extensions/typescript/package.lint.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"eslint": "^8.15.1",
2222
"eslint-plugin-import": "^2.26.0",
2323
"eslint-config-google": "^0.14.0",
24-
"typescript": "^4.9.0",
24+
"typescript": "^5.3.0",
2525
"axios": "^1.3.2",
2626
"chai": "^4.3.7",
2727
"mocha": "^10.2.0",

templates/extensions/typescript/package.nolint.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"devDependencies": {
1515
"@types/chai": "^4.3.4",
1616
"@types/mocha": "^10.0.1",
17-
"typescript": "^4.9.0",
17+
"typescript": "^5.3.0",
1818
"axios": "^1.3.2",
1919
"chai": "^4.3.7",
2020
"mocha": "^10.2.0",

templates/extensions/typescript/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"outDir": "lib",
77
"sourceMap": true,
88
"strict": true,
9-
"target": "es2017"
9+
"target": "es2017",
10+
"skipLibCheck": true
1011
},
1112
"compileOnSave": true,
1213
"include": [

0 commit comments

Comments
 (0)