From 256814a411dd14fe5ff442505ec9eb73c1dbff3d Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Tue, 25 Jun 2024 10:11:12 -0400 Subject: [PATCH 1/2] Guard _finalizationRegistry based on availability. --- packages/app/src/firebaseServerApp.ts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/app/src/firebaseServerApp.ts b/packages/app/src/firebaseServerApp.ts index 6b6c33d316b..8f0b703e187 100644 --- a/packages/app/src/firebaseServerApp.ts +++ b/packages/app/src/firebaseServerApp.ts @@ -32,7 +32,7 @@ export class FirebaseServerAppImpl implements FirebaseServerApp { private readonly _serverConfig: FirebaseServerAppSettings; - private _finalizationRegistry: FinalizationRegistry; + private _finalizationRegistry: FinalizationRegistry | null; private _refCount: number; constructor( @@ -67,9 +67,12 @@ export class FirebaseServerAppImpl ...serverConfig }; - this._finalizationRegistry = new FinalizationRegistry(() => { - this.automaticCleanup(); - }); + this._finalizationRegistry = null; + if (typeof FinalizationRegistry !== 'undefined') { + this._finalizationRegistry = new FinalizationRegistry(() => { + this.automaticCleanup(); + }); + } this._refCount = 0; this.incRefCount(this._serverConfig.releaseOnDeref); @@ -97,7 +100,7 @@ export class FirebaseServerAppImpl return; } this._refCount++; - if (obj !== undefined) { + if (obj !== undefined && this._finalizationRegistry !== null) { this._finalizationRegistry.register(obj, this); } } From 17bff19fdbde675faa6bf5c5c56565658b80c414 Mon Sep 17 00:00:00 2001 From: DellaBitta Date: Fri, 28 Jun 2024 09:58:03 -0400 Subject: [PATCH 2/2] Changeset --- .changeset/clever-dryers-double.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/clever-dryers-double.md diff --git a/.changeset/clever-dryers-double.md b/.changeset/clever-dryers-double.md new file mode 100644 index 00000000000..fcc4d4f7e30 --- /dev/null +++ b/.changeset/clever-dryers-double.md @@ -0,0 +1,6 @@ +--- +'@firebase/app': patch +'firebase': patch +--- + +Guard the use of `FinalizationRegistry` in `FirebaseServerApp` initialization based on the availability of `FinalizationRegistry` in the runtime.