Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical Flow People Involvement: Unable to display People Involvements #6987

Closed
TL41 opened this issue Feb 16, 2024 · 2 comments · Fixed by #6988
Closed

Physical Flow People Involvement: Unable to display People Involvements #6987

TL41 opened this issue Feb 16, 2024 · 2 comments · Fixed by #6988
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing

Comments

@TL41
Copy link
Contributor

TL41 commented Feb 16, 2024

Description

It doesn't look like we can display People Involvements on the Physical Flow page. We can add them via the UI, but they do not display.

We can work on a fix


We think this worked when we added the feature a few releases ago, but it does not look like it works anymore. I didn't do a full trace to see if it recently broke or maybe if there were issues from the start. Either way, it's not working at the moment
#6855

Waltz Version

1.57

Steps to Reproduce

  1. Add a Person Involvement to a Physical Flow
    01 - physical flow

  2. Check the 'involvement' table to confirm the entry was added
    02 - db

  3. Try to add it again and you'll get a message that it may have already been added
    03 - add again to physical flow

  4. Refresh the page to view the entry, but it does not display; console shows an error
    04 - view physical flow error

Expected Result

You should be able to view the involvements that were added

Actual Result

Refresh the page to view the entry, but it does not display; console shows an error

"ServiceBroker::loadData - InvolvementViewService.findAllInvolvementsForEntityByDirection: Server Error - Generic Exception: Cannot determine table fields for entity kind:PHYSICAL_FLOW /"
"Possibly unhandled rejection: {"data":{"message":"Generic Exception: Cannot determine table fields for entity kind:PHYSICAL_FLOW

@TL41 TL41 added the bug Defect affecting the currently released version of Waltz label Feb 16, 2024
@TL41
Copy link
Contributor Author

TL41 commented Feb 16, 2024

The error message originates in waltz-data/src/main/java/org/finos/waltz/data/JooqUtilities.java

So I think it's just a matter of adding a case for PHYSICAL_FLOW to make the table available, but it will take some dev work and testing

@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Feb 19, 2024
@davidwatkins73
Copy link
Member

Thanks for the fix!

@davidwatkins73 davidwatkins73 added this to the done : 1.58 milestone Feb 19, 2024
@davidwatkins73 davidwatkins73 removed this from the done : 1.61.1 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants