Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey Instance: survey_instance_action_queue #6860

Closed
jessica-woodland-scott-db opened this issue Nov 15, 2023 · 0 comments
Closed

Survey Instance: survey_instance_action_queue #6860

jessica-woodland-scott-db opened this issue Nov 15, 2023 · 0 comments
Assignees
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Milestone

Comments

@jessica-woodland-scott-db
Copy link
Contributor

jessica-woodland-scott-db commented Nov 15, 2023

Description

Need a way to queue survey actions from external jobs so that they go through the standard workflow steps for a survey, eg. when reopening, versioning correctly.

Proposal is to have a table to capture actions and then a scheduled job in Waltz to pick these up and implement them.

survey_instance_action_queue

Column Type Description Example
id* Long Identifier for row 1
action* Enum Survey action to be implemented SUBMITTING,REJECTING,REOPENING...
survey_instance_id* Long fk to survey instance table 1
action_params String Object to store additional parameters to pass to the command {comment: "Reason for survey rejection"}
initial_state* Enum Status of the survey instance when the command was issued. Used for verifying the action can still be applied APPROVED, COMPLETED...
submitted_at* Timestamp When was the action submitted  
submitted_by* String Who submitted the action ExampleJob / user_id
actioned_at Timestamp When was the action applied  
status* Enum Indicates whether this action has been applied PENDING / IN_PROGRESS / PRECONDITION_FAILURE / EXECUTION_FAILURE / SUCCESS
error_message String Indicates the reason why the job failed "Initial state mismatch", error thrown during action
provenance String Which system / job added the task to the action list waltz / ExampleJob

Resourcing

We intend to contribute this feature

@jessica-woodland-scott-db jessica-woodland-scott-db added noteworthy probably worth mentioning in release notes DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database labels Nov 15, 2023
@jessica-woodland-scott-db jessica-woodland-scott-db added this to the next : 1.56 milestone Nov 15, 2023
@jessica-woodland-scott-db jessica-woodland-scott-db changed the title Survey Instance: suvrey_instance_action_queue Survey Instance: survey_instance_action_queue Nov 15, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 17, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 17, 2023
@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Nov 24, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
- Supports updating due date and approval due date

#CTCTOWALTZ-2680
finos#6860
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
- Used to inform if an action has been applied via scheduled queue, useful as prints the reason if the action failed.

#CTCTOWALTZ-2680
finos#6860
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Nov 24, 2023
- Used to inform if an action has been applied via scheduled queue, useful as prints the reason if the action failed.

#CTCTOWALTZ-2680
finos#6860
@davidwatkins73 davidwatkins73 added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Projects
None yet
Development

No branches or pull requests

2 participants