Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Physical Flow" as Selectable 'Entity Kind' when Creating a New Involvement Kind #6848

Closed
TL41 opened this issue Nov 10, 2023 · 1 comment

Comments

@TL41
Copy link
Contributor

TL41 commented Nov 10, 2023

Description

On the Physical Flow Page, People section, you cannot add a Person because there are no roles selectable; Unable to add selectable roles because "Physical Flow" does not appear to be an allowable 'Entity Kind'

Classifying this as a feature request; I'm not sure if there are other types that need to be added as well to make sure all entity types can have people associated with them. Also not sure if my trace through below is the proper line of thinking for why this isn't working.

sample endpoint: ../physical-flow/2
image

Additional Details:

  • This Involvement Kind creation screen dropdown “Entity kind these involvements are associated to” is missing PHYSICAL_FLOW

image

  • waltz-ng/client/involvement-kind/components/svelte/InvolvementKindTable.svelte
  • entityList is used for the list

image

  • entityList is a hard-coded list above <-- you can see this list corresponds one-to-one with the dropdown from the GUI
    image

  • ‘entity’ comes from -> import {entity} from "../../../common/services/enums/entity";

  • waltz-ng/client/common/services/enums/entity.js

  • There is a “PHYSICAL_FLOW” entry here but I don’t know if it’s as simple as adding it to the entityList or if other changes are needed to bring this together
    image

Resourcing

We would like to add this request to the Waltz team's feature backlog

@TL41
Copy link
Contributor Author

TL41 commented Nov 13, 2023

I made this change locally and it looks like it works the way we want. I'll create a pull request once we confirm it looks ok. Open to feedback on whether it's truly a one-liner or if there's more work to be done. Also happy to add additional Entity types here if the community has identified others that are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant