Skip to content

Commit e1184c0

Browse files
Merge pull request #7502 from deutschebank/db-contrib/waltz-7470-loading-message-ui
Db contrib/waltz 7470 loading message UI
2 parents 613822d + 91929e5 commit e1184c0

4 files changed

Lines changed: 38 additions & 6 deletions

File tree

waltz-ng/client/logical-flow/components/logical-flows-tabgroup-section/logical-flows-tabgroup-section.html

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,24 @@
4343

4444
<div ng-if="$ctrl.hasFlows">
4545
<waltz-logical-flows-tabgroup parent-entity-ref="$ctrl.parentEntityRef"
46-
filters="$ctrl.filters">
46+
filters="$ctrl.filters"
47+
on-tab-selected="$ctrl.onTabSelected()">
4748
</waltz-logical-flows-tabgroup>
4849
</div>
49-
<div ng-if="!$ctrl.hasFlows">
50+
<div ng-if="!$ctrl.visibility.loading && $ctrl.hasFlows && !$ctrl.tabSelected">
51+
<waltz-warning>
52+
<message>
53+
Please select a view: Choose Graph, Table, or flow Details to display data
54+
</message>
55+
<content></content>
56+
</waltz-warning>
57+
</div>
58+
<div ng-if="$ctrl.loadingStats">
59+
<waltz-loading-notification show="$ctrl.loadingStats"
60+
name="Please wait while we retrieve this data">
61+
</waltz-loading-notification>
62+
</div>
63+
<div ng-if="!$ctrl.loadingStats && !$ctrl.hasFlows">
5064
<waltz-no-data>
5165
<message>
5266
<strong>No related flows found.</strong>

waltz-ng/client/logical-flow/components/logical-flows-tabgroup-section/logical-flows-tabgroup-section.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ const initialState = {
3535
visibility: {
3636
exportButton: false,
3737
sourcesOverlay: false
38-
}
38+
},
39+
tabSelected: false
3940
};
4041

4142

@@ -66,6 +67,10 @@ function controller(serviceBroker) {
6667
vm.$onInit = () => {
6768
};
6869

70+
vm.onTabSelected = () => {
71+
vm.tabSelected = true;
72+
};
73+
6974
vm.$onChanges = (changes) => {
7075

7176
if (vm.parentEntityRef) {
@@ -98,4 +103,4 @@ const component = {
98103
};
99104

100105

101-
export default component;
106+
export default component;

waltz-ng/client/logical-flow/components/logical-flows-tabgroup/logical-flows-tabgroup.html

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,11 @@
7878
</div>
7979
</div>
8080

81+
<div ng-if="!$ctrl.visibility.loadingFlows && $ctrl.loadingError">
82+
<div class="alert alert-warning">
83+
Unable to load the diagram, please refresh and try again
84+
</div>
85+
</div>
8186
</uib-tab>
8287

8388
<uib-tab index="3"

waltz-ng/client/logical-flow/components/logical-flows-tabgroup/logical-flows-tabgroup.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ import FlowDetailPanel from "../../../data-flow/components/svelte/flow-detail-ta
2929

3030
const bindings = {
3131
filters: "<",
32-
parentEntityRef: "<"
32+
parentEntityRef: "<",
33+
onTabSelected: "&?"
3334
};
3435

3536
const initialState = {
@@ -40,7 +41,8 @@ const initialState = {
4041
loadingStats: false
4142
},
4243
FlowDetailPanel,
43-
currentTabIndex: 0
44+
currentTabIndex: 0,
45+
loadingError: false
4446
};
4547

4648
function controller($q,
@@ -69,6 +71,9 @@ function controller($q,
6971
.all([flowPromise, decoratorPromise])
7072
.then(() => {
7173
vm.visibility.loadingFlows = false;
74+
})
75+
.catch(e => {
76+
vm.loadingError = true;
7277
});
7378
};
7479

@@ -85,6 +90,9 @@ function controller($q,
8590
};
8691

8792
vm.tabSelected = (tabName, index) => {
93+
if (_.isFunction(vm.onTabSelected)) {
94+
vm.onTabSelected();
95+
}
8896
if(index > 0) {
8997
loadDetail();
9098
}

0 commit comments

Comments
 (0)