From 40ecd6efc7af8e5fd314c4cef5b294d74bae5196 Mon Sep 17 00:00:00 2001
From: woodjes <jessica.woodland-scott@db.com>
Date: Tue, 27 Feb 2024 14:44:33 +0000
Subject: [PATCH] Default when no value provided on link cell to '-' for
 clickable link

#CTCTOWALTZ-3004
#6908
---
 .../common/components/entity-link/entity-icon-label.html | 5 ++++-
 waltz-ng/client/common/services/enums/entity.js          | 2 +-
 waltz-ng/client/common/svelte/EntityLabel.svelte         | 3 ++-
 .../source-and-target-panel/source-and-target-panel.html | 9 ++++++++-
 .../physical-flow/physical-flow-table-utilities.js       | 4 ++--
 waltz-ng/client/physical-flows/physical-flow-view.html   | 2 +-
 6 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/waltz-ng/client/common/components/entity-link/entity-icon-label.html b/waltz-ng/client/common/components/entity-link/entity-icon-label.html
index 9afb91a758..a21b597cfb 100644
--- a/waltz-ng/client/common/components/entity-link/entity-icon-label.html
+++ b/waltz-ng/client/common/components/entity-link/entity-icon-label.html
@@ -12,11 +12,14 @@
     </waltz-icon>
 
     <span data-testid="entity-name"
-          ng-bind="$ctrl.entityRef.name"
           ng-class="{
             'weil-entity-removed': $ctrl.entityRef.entityLifecycleStatus === 'REMOVED',
             'weil-entity-pending': $ctrl.entityRef.entityLifecycleStatus === 'PENDING'
           }">
+        <span ng-bind="$ctrl.entityRef.name"
+              ng-if="$ctrl.entityRef.name">
+        </span>
+        <span ng-if="!$ctrl.entityRef.name">-</span>
     </span>
 
     <span data-testid="entity-external-id"
diff --git a/waltz-ng/client/common/services/enums/entity.js b/waltz-ng/client/common/services/enums/entity.js
index 8c0d8da8df..4590be429c 100644
--- a/waltz-ng/client/common/services/enums/entity.js
+++ b/waltz-ng/client/common/services/enums/entity.js
@@ -342,7 +342,7 @@ export const entity = {
     PHYSICAL_FLOW: {
         key: "PHYSICAL_FLOW",
         name: "Physical Flow",
-        icon: "qrcode",
+        icon: "arrows-turn-to-dots",
         description: null,
         position: 2200
     },
diff --git a/waltz-ng/client/common/svelte/EntityLabel.svelte b/waltz-ng/client/common/svelte/EntityLabel.svelte
index 3b1f20e100..380ed55d1e 100644
--- a/waltz-ng/client/common/svelte/EntityLabel.svelte
+++ b/waltz-ng/client/common/svelte/EntityLabel.svelte
@@ -17,7 +17,8 @@
 {#if showIcon}
     <EntityIcon kind={ref?.kind}/>
 {/if}
-<span class:removed={ref?.entityLifecycleStatus === 'REMOVED' || ref?.isRemoved}>
+<span class:removed={ref?.entityLifecycleStatus === 'REMOVED' || ref?.isRemoved}
+      class="force-wrap">
     {name}
 </span>
 
diff --git a/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html b/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html
index 10aab8c4cb..dabc77e73e 100644
--- a/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html
+++ b/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html
@@ -201,6 +201,7 @@ <h4>
                 <thead>
                 <tr>
                     <th>Name</th>
+                    <th>Specification</th>
                     <th>Format</th>
                     <th>Transport</th>
                     <th>Frequency</th>
@@ -210,7 +211,8 @@ <h4>
                 <tr ng-repeat="pf in $ctrl.selected.physicalFlows">
                     <td>
                         <a ui-sref="main.physical-flow.view ({ id: pf.id })">
-                            <span ng-bind="pf.specification.name"></span>
+                            <span ng-bind="pf.name" ng-if="pf.name"></span>
+                            <span ng-if="!pf.name"><waltz-icon name="arrows-turn-to-dots"></waltz-icon> - </span>
                         </a>
                         &nbsp;
                         <waltz-icon name="hourglass-2"
@@ -218,6 +220,11 @@ <h4>
                                     uib-tooltip="Changes planned for this physical flow">
                         </waltz-icon>
                     </td>
+                    <td>
+                        <a ui-sref="main.physical-specification.view ({ id: pf.specification.id })">
+                            <span ng-bind="pf.specification.name"></span>
+                        </a>
+                    </td>
                     <td>
                         <waltz-enum-value type="'DataFormatKind'"
                                           key="pf.specification.format"
diff --git a/waltz-ng/client/physical-flow/physical-flow-table-utilities.js b/waltz-ng/client/physical-flow/physical-flow-table-utilities.js
index a43d09c2da..b92983984a 100644
--- a/waltz-ng/client/physical-flow/physical-flow-table-utilities.js
+++ b/waltz-ng/client/physical-flow/physical-flow-table-utilities.js
@@ -22,8 +22,8 @@ import {CORE_API} from "../common/services/core-api-utils";
 
 
 export const columnDef = {
-    name: mkLinkGridCell("Name", "physicalFlow.name", "physicalFlow.id", "main.physical-flow.view"),
-    specName: mkLinkGridCell("Specification Name", "specification.name", "specification.id", "main.physical-specification.view"),
+    name: mkEntityLinkGridCell("Physical Flow Name", "physicalFlow"),
+    specName: mkEntityLinkGridCell("Specification Name", "specification"),
     extId: {field: "physicalFlow.externalId", displayName: "Ext. Id"},
     format: {field: "specification.format", displayName: "Format", cellFilter: "toDisplayName:\"DataFormatKind\""},
     transport: {
diff --git a/waltz-ng/client/physical-flows/physical-flow-view.html b/waltz-ng/client/physical-flows/physical-flow-view.html
index 843e5fd6ac..ab5ca973d7 100644
--- a/waltz-ng/client/physical-flows/physical-flow-view.html
+++ b/waltz-ng/client/physical-flows/physical-flow-view.html
@@ -21,7 +21,7 @@
     <!-- HEADER -->
     <waltz-page-header name="{{ ctrl.physicalFlow.name || ctrl.specification.name }}"
                        small="{{ ctrl.logicalFlow.source.name }} {{ ctrl.logicalFlow ? '&rarr;' : '' }} {{ ctrl.logicalFlow.target.name }}"
-                       icon="qrcode">
+                       icon="{{ctrl.physicalFlow.kind | toIconName:'entity'}}">
         <breadcrumbs>
             <ol class="waltz-breadcrumbs">
                 <li><a ui-sref="main">Home</a></li>