diff --git a/waltz-data/src/main/java/org/finos/waltz/data/physical_flow/PhysicalFlowDao.java b/waltz-data/src/main/java/org/finos/waltz/data/physical_flow/PhysicalFlowDao.java index 4c26667744..d6023a005c 100644 --- a/waltz-data/src/main/java/org/finos/waltz/data/physical_flow/PhysicalFlowDao.java +++ b/waltz-data/src/main/java/org/finos/waltz/data/physical_flow/PhysicalFlowDao.java @@ -80,6 +80,7 @@ public class PhysicalFlowDao { PhysicalFlowRecord record = r.into(PHYSICAL_FLOW); return ImmutablePhysicalFlow.builder() .id(record.getId()) + .name(Optional.ofNullable(record.getName()).orElse("")) .provenance(record.getProvenance()) .specificationId(record.getSpecificationId()) .basisOffset(record.getBasisOffset()) diff --git a/waltz-model/src/main/java/org/finos/waltz/model/physical_flow/PhysicalFlow.java b/waltz-model/src/main/java/org/finos/waltz/model/physical_flow/PhysicalFlow.java index c1706b3ce6..56edb3b28a 100644 --- a/waltz-model/src/main/java/org/finos/waltz/model/physical_flow/PhysicalFlow.java +++ b/waltz-model/src/main/java/org/finos/waltz/model/physical_flow/PhysicalFlow.java @@ -37,6 +37,7 @@ @JsonDeserialize(as = ImmutablePhysicalFlow.class) public abstract class PhysicalFlow implements IdProvider, + NameProvider, IsRemovedProvider, CreatedUserTimestampProvider, DescriptionProvider, diff --git a/waltz-ng/client/common/components/entity-link/entity-icon-label.html b/waltz-ng/client/common/components/entity-link/entity-icon-label.html index 9afb91a758..a21b597cfb 100644 --- a/waltz-ng/client/common/components/entity-link/entity-icon-label.html +++ b/waltz-ng/client/common/components/entity-link/entity-icon-label.html @@ -12,11 +12,14 @@ + + + - + + - + ` }); } diff --git a/waltz-ng/client/common/markdown-utils.js b/waltz-ng/client/common/markdown-utils.js index ba081abbcb..d962e94039 100644 --- a/waltz-ng/client/common/markdown-utils.js +++ b/waltz-ng/client/common/markdown-utils.js @@ -23,7 +23,7 @@ showdown.extension("bootstrap-tables", () => { return [{ type: "output", regex: //g, - replace: "
", + replace: "
", }] }); diff --git a/waltz-ng/client/common/services/enums/entity.js b/waltz-ng/client/common/services/enums/entity.js index 8c0d8da8df..4590be429c 100644 --- a/waltz-ng/client/common/services/enums/entity.js +++ b/waltz-ng/client/common/services/enums/entity.js @@ -342,7 +342,7 @@ export const entity = { PHYSICAL_FLOW: { key: "PHYSICAL_FLOW", name: "Physical Flow", - icon: "qrcode", + icon: "arrows-turn-to-dots", description: null, position: 2200 }, diff --git a/waltz-ng/client/common/svelte/EntityLabel.svelte b/waltz-ng/client/common/svelte/EntityLabel.svelte index 3b1f20e100..380ed55d1e 100644 --- a/waltz-ng/client/common/svelte/EntityLabel.svelte +++ b/waltz-ng/client/common/svelte/EntityLabel.svelte @@ -17,7 +17,8 @@ {#if showIcon} {/if} - + {name} diff --git a/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html b/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html index 10aab8c4cb..dabc77e73e 100644 --- a/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html +++ b/waltz-ng/client/logical-flow/components/source-and-target-panel/source-and-target-panel.html @@ -201,6 +201,7 @@

+ @@ -210,7 +211,8 @@

+
NameSpecification Format Transport Frequency
- + + -   uib-tooltip="Changes planned for this physical flow"> + + + + { + vm.$onChanges = () => { vm.columnDefs = _.isEmpty(vm.optionalColumnDefs) ? defaultColumnDefs : vm.optionalColumnDefs; - vm.tableData = fetchData(vm.parentEntityRef, $q, serviceBroker) + fetchData(vm.parentEntityRef, $q, serviceBroker) .then(data => vm.tableData = data); vm.selectorOptions = mkSelectionOptions( diff --git a/waltz-ng/client/physical-flows/components/physical-flow-and-specification-detail/physical-flow-and-specification-detail.html b/waltz-ng/client/physical-flows/components/physical-flow-and-specification-detail/physical-flow-and-specification-detail.html index 2bf49a0938..3fe35a4b50 100644 --- a/waltz-ng/client/physical-flows/components/physical-flow-and-specification-detail/physical-flow-and-specification-detail.html +++ b/waltz-ng/client/physical-flows/components/physical-flow-and-specification-detail/physical-flow-and-specification-detail.html @@ -17,59 +17,30 @@ --> -
-
- - - - - - - - - - - - - - - - - - - -
- Specification Name: - - - -
- Specification Description: - - -
- Format: - - -
-
-
- -
-
+
+ + + Physical Flow + +
-
- Frequency: +
+ Name +
+
+ +
+
+ +
+
+ Frequency
-
+
@@ -78,26 +49,26 @@
-
- Basis Offset: +
+ Basis Offset
-
- - - +
+ + +
-
- Tags: +
+ Tags
-
+
@@ -114,36 +85,24 @@ - -
-
- Description -
-
- - -
-
- -
-
+
External Identifier
-
- - +
+ +
-
- Additional External Id +
+ Additional External Ids
-
+
@@ -152,13 +111,64 @@
-
+
Provenance
-
- - +
+ +
-
+ +
+
+ Description +
+
+
+ + +
+
+
+
+ +
+ + + Physical Specification + + +
+
+ Name +
+
+ + +
+
+ +
+
+ Format +
+
+ +
+
+ +
+
+ Description +
+
+ +
+
+
diff --git a/waltz-ng/client/physical-flows/components/physical-flow-section/physical-flow-section.js b/waltz-ng/client/physical-flows/components/physical-flow-section/physical-flow-section.js index ef4b794b83..4abd15dfa9 100644 --- a/waltz-ng/client/physical-flows/components/physical-flow-section/physical-flow-section.js +++ b/waltz-ng/client/physical-flows/components/physical-flow-section/physical-flow-section.js @@ -33,6 +33,7 @@ function determineColumnDefs(entityKind) { switch (entityKind) { case "PHYSICAL_SPECIFICATION": return [ + columnDef.name, columnDef.extId, columnDef.source, columnDef.target, @@ -42,9 +43,9 @@ function determineColumnDefs(entityKind) { case "TAG": return [ columnDef.name, + columnDef.extId, columnDef.source, columnDef.target, - columnDef.extId, columnDef.frequency, columnDef.description]; default: diff --git a/waltz-ng/client/physical-flows/physical-flow-view.html b/waltz-ng/client/physical-flows/physical-flow-view.html index fe9173bb85..ab5ca973d7 100644 --- a/waltz-ng/client/physical-flows/physical-flow-view.html +++ b/waltz-ng/client/physical-flows/physical-flow-view.html @@ -19,9 +19,9 @@
- + icon="{{ctrl.physicalFlow.kind | toIconName:'entity'}}">
  1. Home
  2. @@ -35,7 +35,7 @@
  3. physical Flow
  4. -
  5. +
diff --git a/waltz-ng/package-lock.json b/waltz-ng/package-lock.json index fdd032148a..0afbd1bb36 100644 --- a/waltz-ng/package-lock.json +++ b/waltz-ng/package-lock.json @@ -1,6 +1,6 @@ { "name": "waltz-ng", - "version": "1.58.0", + "version": "1.58.1", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/waltz-ng/style/_waltz.scss b/waltz-ng/style/_waltz.scss index 064064bd5e..1fce61f557 100644 --- a/waltz-ng/style/_waltz.scss +++ b/waltz-ng/style/_waltz.scss @@ -224,6 +224,7 @@ textarea { .waltz-display-field-label { color: #705f53; overflow: hidden; + padding-bottom: 0.2em; } .waltz-display-field-value {