Use PMCD returned by mappinganalysis to build minimal graph for query #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9be683b The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
10 tasks
gayathrir11
added
the
Status: Waiting for Backend Change
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2523 +/- ##
==========================================
- Coverage 50.10% 50.02% -0.08%
==========================================
Files 1932 1932
Lines 315871 316641 +770
Branches 12320 12334 +14
==========================================
+ Hits 158258 158400 +142
- Misses 157359 157989 +630
+ Partials 254 252 -2
|
akphi
requested changes
Aug 24, 2023
packages/legend-graph/src/graph-manager/protocol/pure/v1/engine/V1_EngineHelper.ts
Outdated
Show resolved
Hide resolved
packages/legend-graph/src/graph-manager/protocol/pure/v1/V1_PureGraphManager.ts
Outdated
Show resolved
Hide resolved
packages/legend-graph/src/graph-manager/action/analytics/MappingModelCoverageAnalysis.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/LegendQueryApplicationPlugin.ts
Outdated
Show resolved
Hide resolved
...on-dsl-data-space/src/graph-manager/protocol/pure/DSL_DataSpace_PureGraphManagerExtension.ts
Outdated
Show resolved
Hide resolved
gayathrir11
force-pushed
the
load
branch
2 times, most recently
from
d5cbfe1 to
f96aef9
Compare
gayathrir11
force-pushed
the
load
branch
4 times, most recently
from
3547ecd to
cf2427d
Compare
akphi
approved these changes
Oct 20, 2023
YannanGao-gs
approved these changes
Nov 10, 2023
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
|
|
3 tasks
|
updated/cleaned by #3488 |
|
superseded by #3488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on finos/legend-engine#2152
closes #2346
How did you test this change?