We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, we are setting letter-spacing values to a percentage, but they need to be pixels.
Here is what the values should be by default. I have updated the TB.css file, but it is overwritten by values coming from the SDK.
--body1LetterSpacing: calc(.02 * var(--body1FontSize)); --body1-boldLetterSpacing: calc(.02 * var(--body1FontSize)); --body2-boldLetterSpacing: calc(.0175 * var(--body2-boldFontSize)); --body2LetterSpacing: calc(.0175 * var(--body2-boldFontSize)); --body3-boldLetterSpacing: calc(.0225 * var(--body3-boldFontSize)); --subtitle1LetterSpacing: calc(.02 * var(--subtitle1FontSize)); --subtitle2LetterSpacing: calc(.0175 * var(--subtitle2FontSize)); --captionLetterSpacing: calc(.015 * var(--captionFontSize)); --caption-boldLetterSpacing: calc(.015 * var(--captionFontSize)); --overlineLetterSpacing: calc(.012 * var(--overlineFontSize)); --overline-largeLetterSpacing: calc(.0175 * var(--overline-largeFontSize)); --label-1LetterSpacing: calc(.0175 * var(--label-1FontSize)); --label-1-allCapsLetterSpacing: calc(.0175 * var(--label-1-allCapsFontSize)); --label-2LetterSpacing: calc(.015 * var(--label-2FontSize)); —label-2-allCapsLetterSpacing: calc(.015 * var(--label-2-allCapsFontSize)); --label-smallLetterSpacing: calc(.012 * var(--label-smallFontSize)); --CTALetterSpacing: calc(.012 * var(--CTAFontSize)); --CTA-SmallLetterSpacing: calc(.0175 * var(--CTA-SmallFontSize)); --smallLetterSpacing: calc(.013 * var(--smallFontSize)); --small-semiboldLetterSpacing: calc(.013 * var(--smallFontSize)); --statLetterSpacing: calc(.013 * var(--statFontSize));
The text was updated successfully, but these errors were encountered:
PR is ready for review: finos/a11y-theme-builder-sdk#153
Sorry, something went wrong.
evangk6
No branches or pull requests
Problem/Concern
Currently, we are setting letter-spacing values to a percentage, but they need to be pixels.
Proposed Solution
Here is what the values should be by default. I have updated the TB.css file, but it is overwritten by values coming from the SDK.
--body1LetterSpacing: calc(.02 * var(--body1FontSize));
--body1-boldLetterSpacing: calc(.02 * var(--body1FontSize));
--body2-boldLetterSpacing: calc(.0175 * var(--body2-boldFontSize));
--body2LetterSpacing: calc(.0175 * var(--body2-boldFontSize));
--body3-boldLetterSpacing: calc(.0225 * var(--body3-boldFontSize));
--subtitle1LetterSpacing: calc(.02 * var(--subtitle1FontSize));
--subtitle2LetterSpacing: calc(.0175 * var(--subtitle2FontSize));
--captionLetterSpacing: calc(.015 * var(--captionFontSize));
--caption-boldLetterSpacing: calc(.015 * var(--captionFontSize));
--overlineLetterSpacing: calc(.012 * var(--overlineFontSize));
--overline-largeLetterSpacing: calc(.0175 * var(--overline-largeFontSize));
--label-1LetterSpacing: calc(.0175 * var(--label-1FontSize));
--label-1-allCapsLetterSpacing: calc(.0175 * var(--label-1-allCapsFontSize));
--label-2LetterSpacing: calc(.015 * var(--label-2FontSize));
—label-2-allCapsLetterSpacing: calc(.015 * var(--label-2-allCapsFontSize));
--label-smallLetterSpacing: calc(.012 * var(--label-smallFontSize));
--CTALetterSpacing: calc(.012 * var(--CTAFontSize));
--CTA-SmallLetterSpacing: calc(.0175 * var(--CTA-SmallFontSize));
--smallLetterSpacing: calc(.013 * var(--smallFontSize));
--small-semiboldLetterSpacing: calc(.013 * var(--smallFontSize));
--statLetterSpacing: calc(.013 * var(--statFontSize));
The text was updated successfully, but these errors were encountered: