Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Entering letter spacing values wrong #764

Open
lwnoble opened this issue Jan 8, 2024 · 1 comment
Open

[SDK] Entering letter spacing values wrong #764

lwnoble opened this issue Jan 8, 2024 · 1 comment
Assignees
Labels
bug Something isn't working sdk Software development kit

Comments

@lwnoble
Copy link
Contributor

lwnoble commented Jan 8, 2024

Problem/Concern

Currently, we are setting letter-spacing values to a percentage, but they need to be pixels.

Proposed Solution

Here is what the values should be by default. I have updated the TB.css file, but it is overwritten by values coming from the SDK.

--body1LetterSpacing: calc(.02 * var(--body1FontSize));
--body1-boldLetterSpacing: calc(.02 * var(--body1FontSize));
--body2-boldLetterSpacing: calc(.0175 * var(--body2-boldFontSize));
--body2LetterSpacing: calc(.0175 * var(--body2-boldFontSize));
--body3-boldLetterSpacing: calc(.0225 * var(--body3-boldFontSize));
--subtitle1LetterSpacing: calc(.02 * var(--subtitle1FontSize));
--subtitle2LetterSpacing: calc(.0175 * var(--subtitle2FontSize));
--captionLetterSpacing: calc(.015 * var(--captionFontSize));
--caption-boldLetterSpacing: calc(.015 * var(--captionFontSize));
--overlineLetterSpacing: calc(.012 * var(--overlineFontSize));
--overline-largeLetterSpacing: calc(.0175 * var(--overline-largeFontSize));
--label-1LetterSpacing: calc(.0175 * var(--label-1FontSize));
--label-1-allCapsLetterSpacing: calc(.0175 * var(--label-1-allCapsFontSize));
--label-2LetterSpacing: calc(.015 * var(--label-2FontSize));
—label-2-allCapsLetterSpacing: calc(.015 * var(--label-2-allCapsFontSize));
--label-smallLetterSpacing: calc(.012 * var(--label-smallFontSize));
--CTALetterSpacing: calc(.012 * var(--CTAFontSize));
--CTA-SmallLetterSpacing: calc(.0175 * var(--CTA-SmallFontSize));
--smallLetterSpacing: calc(.013 * var(--smallFontSize));
--small-semiboldLetterSpacing: calc(.013 * var(--smallFontSize));
--statLetterSpacing: calc(.013 * var(--statFontSize));

@lwnoble lwnoble added the bug Something isn't working label Jan 8, 2024
@aaronreed708 aaronreed708 added the sdk Software development kit label Jan 11, 2024
@aaronreed708 aaronreed708 moved this to High Priority in ThemeBuilder Mar 8, 2024
@evangk6 evangk6 assigned evangk6 and unassigned smithbk Mar 14, 2024
@evangk6
Copy link
Contributor

evangk6 commented Mar 21, 2024

PR is ready for review:
finos/a11y-theme-builder-sdk#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdk Software development kit
Projects
Status: High Priority
Development

No branches or pull requests

4 participants