Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix dotest #1061

Open
aaronreed708 opened this issue Nov 23, 2024 · 1 comment
Open

[SDK] Fix dotest #1061

aaronreed708 opened this issue Nov 23, 2024 · 1 comment
Assignees
Labels
sdk Software development kit

Comments

@aaronreed708
Copy link
Contributor

aaronreed708 commented Nov 23, 2024

Problem/Concern

As we will start running the SDK tests more often as we add changes to the SDK, we need to make sure that they are working correctly.

Currently test/dotest.ts is failing in two places:

  1. assert failing on line 159 because CSSVarGroup listener for ds.organisms.hero is being called 8 times instead of the expected 4 times.
  2. Running the "TEST: BUTTON SELECTION 0" fails during listener notification because the theme's gradient1 and gradient2 don't have "from" values.
    • failing listener is: _tb.cssGenerator.CSSTheme.button

Proposed Solution

Fix the testcase so that it runs to successful completion.

@aaronreed708 aaronreed708 added the sdk Software development kit label Nov 23, 2024
@aaronreed708 aaronreed708 self-assigned this Nov 23, 2024
@aaronreed708
Copy link
Contributor Author

Debugging exception in notification listener:

Call Stack:
colorTheme.getModeShadeGroups <-- throwing error line 461
colorTheme.getShadeGroups
cssGenerator.shadeGroupListener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Software development kit
Projects
Status: No status
Development

No branches or pull requests

1 participant