Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TB] Questions around multiple Color Themes in new UI #1029

Open
aaronreed708 opened this issue Sep 19, 2024 · 1 comment
Open

[TB] Questions around multiple Color Themes in new UI #1029

aaronreed708 opened this issue Sep 19, 2024 · 1 comment
Assignees
Labels
awaiting feedback Issue is blocked until awaiting feedback question Further information is requested theme builder app Theme Builder application

Comments

@aaronreed708
Copy link
Contributor

Problem/Concern

After discussing #820 wireframes and UX with @omesh-omg we had a few questions.

  1. When the user gets to "Step 3, Light and Dark Mode" and starts to assign values to the Primary, Secondary and Tertiary colors, what do the other expandable fields look like? For example, do the Button or Hotlinks "colorized" dropdowns have a default color assigned as soon as a primary color is selected? According to the text for those sections, they appear to get a default value. But if that is true and I go to modify the default colorized value, for example, would the "Suggested Changes" modal dialog appear even though I've never set the value before? I might want to play with a lot of the values initially and dealing with the popup every time might be annoying.
  2. Do the Light and Dark swatches in both the Button and Hotlinks sections do anything? They don't seem to be dropdowns. Are they actionable? What should their default values be?
  3. How should we refer to they styles generated by the named Color Themes that we add to the design system? If I add a color theme called "HR" and end up saving that design system and using it in my application, would the relevant style be var(--hr-button) but the default Color Theme would use var(--button)?

Note: I assume that we'll need to do name collision validation, @omesh-omg, to make sure no one duplicates a name. In addition, we'll probably need to make sure that only characters that can be used in CSS selectors can be entered in the color theme name.

@aaronreed708 aaronreed708 added question Further information is requested theme builder app Theme Builder application awaiting feedback Issue is blocked until awaiting feedback labels Sep 19, 2024
@aaronreed708
Copy link
Contributor Author

aaronreed708 commented Nov 17, 2024

More questions (which I asked today in the Figma file, so look there for possible answers):

  1. If I am looking at the button molecule, will I be able to change the currently selected theme so that I can see the different button colors on the page without having to navigate back to the color theme and select a different theme?
  2. If we have multiple themes, what are we producing for MUI theme files? Will we have a different MUI theme file for each color theme?
  3. Currently in Theme Builder, a design system will not consider the ColorThemes node "initialized" unless ALL of the named themes are initialized. Which means if we add a new theme, then atoms, molecules, organism, etc. nodes won't be enabled until the new theme has been initialized. Note: need to double check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Issue is blocked until awaiting feedback question Further information is requested theme builder app Theme Builder application
Projects
Status: No status
Development

No branches or pull requests

2 participants