Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sizing guidelines #7

Open
nevf opened this issue Apr 9, 2019 · 1 comment
Open

Sizing guidelines #7

nevf opened this issue Apr 9, 2019 · 1 comment

Comments

@nevf
Copy link

nevf commented Apr 9, 2019

@finnhvman You say

Components can be resized fluidly to match layout needs, otherwise they take up the size necessary.

Can you write up some guidelines how how we should actually do resizing.

For example matter buttons have min-width, height and line-height specified. So they don't actually take up the size necessary. Should we override all three of these.

Some css libs offer small, large etc. style overrides. Is this something you might add to a future release?

@finnhvman
Copy link
Owner

There are certain minimum widths for the buttons according to the Material Design spec. Usually the caption is wider than the minimum width, in those cases the button takes up the size necessary.

For now you have to override all three. (I will probably remove line-height property from the buttons).

Sizing guidelines is a good idea I should note. I don't see straightforward way to figure out the small, large, etc. style overrides, so I would leave it up to the library users. I think there's no one-size-fits-all for these needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants